Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive: fix build with Perl 5.38 #156019

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 30, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Overriding CCFLAGS results in mismatches between modules built with perl Build.PL and perl Makefile.PL.

I think the reason we used CCFLAGS was to help Tk find freetype. Instead, try using X11INC and X11LIB similar to MacPorts and Nix.


closes #155568

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Nov 30, 2023
@github-actions github-actions bot added lua Lua use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue perl Perl use is a significant feature of the PR or issue long build Set a long timeout for formula testing large-bottle-upload [DEPRECATED] Pull request requires a large runner to upload bottles labels Nov 30, 2023
@p-linnane p-linnane added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 30, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 30, 2023
@cho-m cho-m added CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Nov 30, 2023
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Nov 30, 2023
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @cho-m! Thank you!

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 30, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 30, 2023
Merged via the queue into Homebrew:master with commit 71b8e84 Nov 30, 2023
28 of 29 checks passed
@cho-m cho-m deleted the texlive-fix-perl5.38 branch November 30, 2023 23:41
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. java Java use is a significant feature of the PR or issue large-bottle-upload [DEPRECATED] Pull request requires a large runner to upload bottles long build Set a long timeout for formula testing lua Lua use is a significant feature of the PR or issue outdated PR was locked due to age perl Perl use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants