-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icu4c 74.2 #153108
icu4c 74.2 #153108
Conversation
Promising initial run. Linux:
#if U_ICU_VERSION_MAJOR_NUM >= 74
#define BA_LB_COUNT (U_LB_COUNT - 8)
...
macOS:
Any non-disabled PHP versioned formula also needs revision bumping here: (Haven't checked dependent tests yet as they're still running) |
Note that active support for |
It'll probably just be a case of we'll do it if this PR ships before that date, and not if it doesn't. PHP's light enough to only take 10-20 minutes to build. Focus first is fixing the other things though. |
Fix for |
Looks like none of the PHP formulae are being revision bumped here. 8.0 isn't a concern anymore but anything newer, including the latest, is. |
Linux failures:
|
Ignoring missing revision bumps and failures I already fixed in referenced PRs, the main failures are:
Outside those, the rest look like flaky dependent tests or other unrelated issues:
|
Added some extra revision bumps. Dealing with patches for Will need another rebase before running. |
Linux failed to build
|
74.2 is out. |
Thanks to everyone who contributed to the effort to get this version bump merged! |
Awesome work! 💯 |
Follow ups:
|
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?