Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dafny: use dotnet@6 and openjdk@17 #117764

Closed
wants to merge 1 commit into from
Closed

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 9, 2022

  • use dotnet@6 and openjdk@17
  • use system python3 on macOS
  • remove gradle build dependency since dafny runs ./gradlew instead of gradle command so gradle dependency is not used
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Split from #115365.

* use `dotnet@6` and `openjdk@17`
* use system python3 on macOS
* remove `gradle` build dependency since `dafny` runs ./gradlew
  instead of gradle command so `gradle` dependency is not used
@BrewTestBot BrewTestBot added dotnet .NET use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue labels Dec 9, 2022
@@ -21,10 +22,13 @@ class Dafny < Formula
sha256 cellar: :any_skip_relocation, x86_64_linux: "25d87dc6b3a2041668a3e4100d3e44c61bee2a772a8405fdc8fc63d1ac35a200"
end

depends_on "gradle" => :build
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./gradlew is run during make exe as part of C# project https://github.com/dafny-lang/dafny/blob/v3.9.1/Source/DafnyRuntime/DafnyRuntime.csproj#L47

    <Exec WorkingDirectory="DafnyRuntimeJava" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" Command="./gradlew -q build" />

Comment on lines +26 to +29
# We use the latest Java version that is compatible with gradlew version in `dafny`.
# https://github.com/dafny-lang/dafny/blob/v#{version}/Source/DafnyRuntime/DafnyRuntimeJava/gradle/wrapper/gradle-wrapper.properties
# https://docs.gradle.org/current/userguide/compatibility.html
depends_on "openjdk@17"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Dec 10, 2022
@BrewTestBot
Copy link
Member

:shipit: @p-linnane has triggered a merge.

@cho-m cho-m deleted the dafny-deps branch December 10, 2022 19:31
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dotnet .NET use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants