dafny: use dotnet@6 and openjdk@17
#117764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use `dotnet@6` and `openjdk@17` * use system python3 on macOS * remove `gradle` build dependency since `dafny` runs ./gradlew instead of gradle command so `gradle` dependency is not used
BrewTestBot
added
dotnet
cho-m
commented
Dec 9, 2022
| @@ -21,10 +22,13 @@ class Dafny < Formula | |||
| sha256 cellar: :any_skip_relocation, x86_64_linux: "25d87dc6b3a2041668a3e4100d3e44c61bee2a772a8405fdc8fc63d1ac35a200" | |||
| end | |||
|
|
|||
| depends_on "gradle" => :build | |||
There was a problem hiding this comment.
./gradlew is run during make exe as part of C# project https://github.com/dafny-lang/dafny/blob/v3.9.1/Source/DafnyRuntime/DafnyRuntime.csproj#L47
<Exec WorkingDirectory="DafnyRuntimeJava" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" Command="./gradlew -q build" />
cho-m
commented
Dec 9, 2022
Comment on lines
+26
to
+29
| # We use the latest Java version that is compatible with gradlew version in `dafny`. | ||
| # https://github.com/dafny-lang/dafny/blob/v#{version}/Source/DafnyRuntime/DafnyRuntimeJava/gradle/wrapper/gradle-wrapper.properties | ||
| # https://docs.gradle.org/current/userguide/compatibility.html | ||
| depends_on "openjdk@17" |
There was a problem hiding this comment.
Gradle 7.4.2 is used at https://github.com/dafny-lang/dafny/blob/v3.9.1/Source/DafnyRuntime/DafnyRuntimeJava/gradle/wrapper/gradle-wrapper.properties
Officially, that is compatible up to Java 17.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet@6andopenjdk@17gradlebuild dependency sincedafnyruns ./gradlew instead of gradle command sogradledependency is not usedbrew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Split from #115365.