Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet 7.0.100 #115365

Closed
wants to merge 1 commit into from
Closed

dotnet 7.0.100 #115365

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 10, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added do not merge in progress Stale bot should stay away labels Nov 10, 2022
@BrewTestBot BrewTestBot added icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing labels Nov 10, 2022
@cho-m
Copy link
Member Author

cho-m commented Dec 1, 2022

Just noting that I haven't been able to build locally yet. Haven't had time to figure out build failure after updating patches.

Have been testing ARM build, so may try to get Intel build working first, which is usually better supported/tested.

@ZhongRuoyu ZhongRuoyu mentioned this pull request Dec 5, 2022
Closed
@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed long build Set a long timeout for formula testing labels Dec 6, 2022
@BrewTestBot BrewTestBot added the long build Set a long timeout for formula testing label Dec 6, 2022
@cho-m cho-m removed the long build Set a long timeout for formula testing label Dec 6, 2022
@BrewTestBot BrewTestBot added the long build Set a long timeout for formula testing label Dec 7, 2022
@cho-m cho-m added openssl-3-migration Related to switching to an OpenSSL 3 dependency python-3.11-migration and removed openssl-3-migration Related to switching to an OpenSSL 3 dependency labels Dec 7, 2022
@cho-m cho-m removed the long build Set a long timeout for formula testing label Dec 7, 2022
@cho-m
Copy link
Member Author

cho-m commented Dec 7, 2022

Got ARM build working. Won't know about Intel until long timeout is available.

However, remaining problem is dependents don't support .NET 7:

  • dafny - no support. tried head build
  • jackett - no support. tried head build
  • gitversion - support planned for next release 6.x. Available in HEAD but may be tricky to backport GitTools/GitVersion@5974053

@cho-m cho-m mentioned this pull request Dec 7, 2022
Merged
@cho-m
Copy link
Member Author

cho-m commented Dec 7, 2022 •
edited
Loading

Most likely will create dotnet@6 formula. It is an LTS release with support until Nov 2024

Also, not sure what is going on with Linux build time. Either .NET 7 takes noticeably longer to build or something is going wrong.

@cho-m cho-m added the CI-linux-self-hosted Build on Linux self-hosted runner label Dec 7, 2022
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 7, 2022
@cho-m cho-m changed the title dotnet 7.0.100 dotnet 7.0.100, dotnet@6 6.0.111 (new formula), jackett 0.20.2328 Dec 7, 2022
cho-m
cho-m commented Dec 7, 2022
View reviewed changes
Formula/dotnet.rb Show resolved Hide resolved
cho-m
cho-m commented Dec 7, 2022
View reviewed changes
Formula/dotnet.rb Show resolved Hide resolved
cho-m
cho-m commented Dec 7, 2022
View reviewed changes
Formula/[email protected] Outdated Show resolved Hide resolved
@cho-m cho-m added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 7, 2022
This was referenced Dec 7, 2022
Closed
Closed
@cho-m cho-m added build failure CI fails while building the software linux Linux is specifically affected labels Dec 9, 2022
This was referenced Dec 9, 2022
Closed
Closed
Closed
@BrewTestBot BrewTestBot removed the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 9, 2022
@cho-m cho-m changed the title dotnet 7.0.100, dotnet@6 6.0.111 (new formula), jackett 0.20.2328 dotnet 7.0.100 Dec 9, 2022
@cho-m cho-m added in progress Stale bot should stay away and removed CI-linux-self-hosted Build on Linux self-hosted runner build failure CI fails while building the software labels Dec 11, 2022
@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. ready to merge PR can be merged once CI is green and removed linux Linux is specifically affected CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Dec 12, 2022
@cho-m cho-m removed the in progress Stale bot should stay away label Dec 14, 2022
@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@ZhongRuoyu ZhongRuoyu mentioned this pull request Dec 15, 2022
Closed
@cho-m cho-m deleted the bump-dotnet-7.0.100 branch December 15, 2022 18:17
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
@chenrui333 chenrui333 added the python Python use is a significant feature of the PR or issue label Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.11-migration ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cho-m @BrewTestBot @chenrui333