Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated zap items for amazon-music #97129

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Updated zap items for amazon-music #97129

merged 1 commit into from
Jan 7, 2021

Conversation

adithyasunil26
Copy link
Contributor

@adithyasunil26 adithyasunil26 commented Dec 31, 2020

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@miccal miccal added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jan 6, 2021
@miccal
Copy link
Member

miccal commented Jan 7, 2021

Thank you @adithyasunil26.

@miccal miccal merged commit 22b3bec into Homebrew:master Jan 7, 2021
@adithyasunil26 adithyasunil26 deleted the amazon-music-zap branch January 7, 2021 09:27
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants