-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casks without zap #88469
Comments
@ran-dall Because you might be interested in the information: there’s almost four thousand casks without a |
imgur #88545 Also, I believe that paintbrush already has zap stanza |
Also, I can write here if some more casks already have zap stanza |
There was a bug in the script and it collected way more than it was supposed to. It was a coincidence that all the ones I checked didn’t have a @ran-dall Update on that. They’re less than two and a half thousand. |
@vitorgalvao I'm working on this with the ML. I need a day or two. I'll have all the zaps inputted. Should I push to this PR? |
You mean the ML will be able to add all missing zaps? |
...yeah, and it should be able to maintain them too. |
That’s great. You can outright close the issue when that’s done, then. |
This is where #85820 and/or homebrew-createzap would come in handy… |
Added zap for Freeplane on #92370 |
Added zap stanza for fldigi on 92764 |
@muneebmahmed added zap stanza for the cask |
Added zap stanza for |
Added zap stanza for swish on #94909 |
Thank you all for the updates and the comments. To clarify, in case you ever check the list and don’t see any boxes ticked, that’s because I semi-regularly regenerate the list (with only the ones missing). |
Added zap stanza for pyfa in #97090 |
Added zap stanza for tencent-lemon in #97181 |
Added zap stanza for ringcentral-phone in #99161 |
Added zap to
|
List in top post updated. I usually do it without mentioning, but haven’t done so in a while so wanted to reinforce it’s still happening. |
Added zap to
|
Added zap to
|
Added zap to:
|
@razvanazamfirei Will you keep the list up to date? If so, I can just link to it in the top post, seems like a better approach. We could also delete the script if you’re not using it. |
@vitorgalvao, I wasn't aware of the script! I'll try modify it to include the download count so it's easy for people to prioritize. |
Note the script is to help update the top post, not necessarily to be used on its own. So if you have a different way of generating the list and are keeping it up-to-date (even once a month should suffice) we can just link to it above. |
@vitorgalvao, my update to the script was merged and now the list includes (and is sorted by) the download count adds. Thanks for pointing me towards it. |
Added PRs to add zaps to |
No zap:
|
No zap:
|
Added zap to beamer in #146813 |
[why] Casks without zap stanza are flagged; all casks should contain them. The font casks do not really need zap. [how] What is the right way to say 'we considered zap, but do not need it'? It seems that other people add a comment (the same comment). For example here: Homebrew/homebrew-cask#119090 And that seems rather widespread. git/homebrew-cask/Casks$ git grep '# No zap stanza required' | wc -l 101 Include the same in our casks. [note] Homebrew/homebrew-cask#88469 Signed-off-by: Fini Jastrow <[email protected]>
Is there an easy way to sort this list by "most installed recently"? |
Added zap to love in #156762. |
Curious, does the
I tried running it and my clipboard seems to be blank at the end of it:
It might be useful to have a normal 'print to console' mode/flag, rather than using I see that the list of casks that need fixing hasn't been updated in quite a while; any chance of getting an update on this: I haven't skimmed through all of the posts on this issue to see if there were any later updates about this, but I was wondering if this automation for adding/maintaining the zap clauses ever got completed?
|
[why] Casks without zap stanza are flagged; all casks should contain them. The font casks do not really need zap. [how] What is the right way to say 'we considered zap, but do not need it'? It seems that other people add a comment (the same comment). For example here: Homebrew/homebrew-cask#119090 And that seems rather widespread. git/homebrew-cask/Casks$ git grep '# No zap stanza required' | wc -l 101 Include the same in our casks. [note] Homebrew/homebrew-cask#88469 Signed-off-by: Fini Jastrow <[email protected]>
This is a list of casks without a
zap
stanza. It is suitable for contributors of any experience level.zap
s do not require any special tool to figure out, but they can help speed up the process.If you make a PR to add a cask from this list, please comment back with the name of the cask and a link to the PR. It helps with knowing when to rebuild the list.
Thank you for helping us with these.
The text was updated successfully, but these errors were encountered: