Convert 7 Casks to depends_on :macos
#7760
Conversation
|
@vitorgalvao I left these lower down near the |
| @@ -23,11 +23,11 @@ | |||
|
|
|||
| app 'Deeper.app' | |||
|
|
|||
| caveats do | |||
| os_version_only('10.4', '10.5', '10.6', '10.7', '10.8', '10.9', '10.10') | |||
| depends_on :macos => %w{10.4 10.5 10.6 10.7 10.8 10.9 10.10} | |||
There was a problem hiding this comment.
Why not '>= 10.4' instead? Same for maintenance. Are we preferring numbers over names? It’s the same to me, but I was going to start using the version symbols.
|
I'll switch them to the symbols. For those two Casks, every release is tailored to a single OS X release, as they do some very system-specific fiddling. So, nobody should install the 10.10 version on 10.11. I was going to revise the |
from caveats `os_version_only`.
rolandwalker
force-pushed
the
mass_convert_depends_on_macos
branch
from
da3b8ff to
f3ef189
Compare
| :lion | ||
| :mountain_lion | ||
| :mavericks | ||
| } |
There was a problem hiding this comment.
Should this not also include :yosemite? Same for maintenance.rb
from caveats `os_version_only`. Also tweak unrelated version-specific caveat.
from caveats `os_version_only`. Also tweak unrelated version-specific caveat.
from caveats `os_version_only`.
from caveats `os_version_only`.
from caveats `os_version_only`.
from caveats `os_version_only`.
rolandwalker
force-pushed
the
mass_convert_depends_on_macos
branch
from
f3ef189 to
c4122c0
Compare
Convert 7 Casks to `depends_on :macos`
It is OK to use this feature, even though it is very new, because forward-compatibility code has been in release for some time.