Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typed.rb: depends_on macos #7744

Merged
merged 1 commit into from
Dec 3, 2014
Merged

typed.rb: depends_on macos #7744

merged 1 commit into from
Dec 3, 2014

Conversation

vitorgalvao
Copy link
Member

@rolandwalker @ndr-qef Any preference on the position of these stanzas?

@rolandwalker
Copy link
Contributor

At the moment I would say lower down, because I was thinking to put the new name stanza high up. But this is not completely thought through.

@vitorgalvao
Copy link
Member Author

I put it this high because my mental image of “depends on” is as a requirement, like “this is the first thing you need to check before continuing, so it should be near the top”.

But this is only my mental model, naturally, and it may very well not be a wide-spread association (which is why I thought it important to ping you.

So were you thinking below or on top of app?

@vitorgalvao
Copy link
Member Author

@rolandwalker Your reasoning on #7760 definitely makes sense. I’ve updated this PR to reflect it.

@tapeinosyne
Copy link
Contributor

Preserving the previous position near caveats seems sensible.

@rolandwalker
Copy link
Contributor

Being declarative means we can do whatever makes sense to humans.

rolandwalker added a commit that referenced this pull request Dec 3, 2014
@rolandwalker rolandwalker merged commit 75d7fd0 into Homebrew:master Dec 3, 2014
@vitorgalvao vitorgalvao deleted the typed-dependency branch December 3, 2014 18:28
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants