-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gpg stanza to compatible casks #6185
Add gpg stanza to compatible casks #6185
Conversation
@ndr-qef I'm adding more casks to your compatible list above. |
@fanquake, thanks. Unfortunately, @vitorgalvao, I would like your opinion on cask layout. What should be the canonical position of the Something to consider is that many signatures are found at urls which equal their package's, plus E.g. gpg 'https://example.com/package.dmg.asc'
:key_id '…'
url 'https://example.com/package.dmg'
url 'https://example.com/package.dmg'
gpg "#{url}.asc"
:key_id '…' |
That also sounds like the best option, to me. We already put |
12 casks of varying key type should suffice for a start. Once Travis passes, I will mark this PR as ready. |
@ndr-qef Ah I see. Also agree with your layout suggestion |
I crawled the most predictable urls for gpg signatures, obtaining 8 new candidates. This PR now includes all gpg signatures which can be reasonably autodiscovered. Casual statistic: approximately 1% of our casks offer gpg verification. |
Add gpg stanza to compatible casks
Even though we’re not quite there yet regarding GPG support (cf. issue #5971 and PR Homebrew/brew#1335), I’d still prefer for new casks to have `gpg` stanzas where detached signatures are available (cf. PR #6185). For details on the authenticity of the public key, see: - https://support.1password.com/command-line-getting-started/#set-up-the-command-line-tool - https://keybase.io/1password
Add
gpg
stanza to casks for which keys and detached signatures are available. Feel free to add entries to the list.Known compatible:
armory— no detached signaturebitcoin— no detached signaturewireshark— no detached signature