cask: activate GPG verification on install #1335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and store the result in a field instead. Failure handling is delegated.
Specifically, handle cases where the most recent metadata folder was created by something other than GpgCheck, e.g. an `install --force`.
and associated support files: test Casks, binaries, signature.
|
|
|
Yup, those are left over from when we had a bunch of similar sized fixtures. These commits are over a year old; haven't gotten around to cleaning them up yet. AFK right now, but will add the |
|
Added. |
8 tasks
|
@jawshooah Any news on this? If it's too stale might just be worth closing out. |
|
Sadly no, no news, and likely none to come for a while. I agree we should just close this for now. We can re-open when I have time to clean this up later, or someone else can feel free to pick up where I left off whenever. |
10 tasks
commitay
pushed a commit
to Homebrew/homebrew-cask
that referenced
this pull request
Sep 20, 2017
Even though we’re not quite there yet regarding GPG support (cf. issue #5971 and PR Homebrew/brew#1335), I’d still prefer for new casks to have `gpg` stanzas where detached signatures are available (cf. PR #6185). For details on the authenticity of the public key, see: - https://support.1password.com/command-line-getting-started/#set-up-the-command-line-tool - https://keybase.io/1password
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Following up on Homebrew/homebrew-cask#16090.
@Homebrew/cask @fanquake @ndr-qef