-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Xamarin Studio, as well as the Android and iOS platforms #5135
Conversation
@Fapper Feel free to chime in on this PR. |
I like your solution much better than mine. Didn't know that was possible... smart! @vitorgalvao, filing to have my two pull requests reverted in favor of this pull request. Thanks for helping me make the casks, I learned a ton and will hopefully be able to use this knowledge for future casks. |
Since you’re both in agreement, and you both use this (I don’t), I’m inclined to trust your judgement. However, I’m not sure this approach is the best one. You’re getting the apps in a manner that is not the one intended by the vendor. I feel that if we have to resort to sniffing traffic to find the url (and we can’t use one that always tracks the latest version), these will likely linger in comparison to I don’t feel strongly about it, however, and could certainly be convinced otherwise. This also bears some small resemblance to the recent Sketchup pull request, where @rolandwalker expressed a desire to break from our old pattern (where including all these would make sense), but we haven’t yet discussed specifics, so I’m requesting his input on this. Either way, @jamesottaway, for these to be included back, I simply ask they be added as they were last, regarding stanza order. |
@jamesottaway and @Fapper, thanks! @vitorgalvao I had not intended to create new policy in #5090, will have to review it. I don't worry too much over what goes into the versions repo, because one day those Casks can come back: if we implement a The Casks in this PR don't install different versions of As to sniffing the URL for the |
My concern with different versions of the same app was mainly tied to To be clear, I also have no problem with sniffing the traffic, and also found it an ingenious solution. My sole concern was with future updates, as we don’t want to chain @jamesottaway with the task of updating these indefinitely. Checking the urls again, however, they seem simple enough to update through deduction alone. It’s settled, then. @jamesottaway would you mind restoring the stanza order, as mentioned, so we can merge this? |
Thanks for the feedback everyone.
Is it worth leaving a comment in the cask with information on to how to update it? It's a valid concern to be able to keep them up-to-date if or when I no longer can.
Since these casks replace the
Done. |
I think When I said “concern” I should’ve been clearer. I didn’t mean in the sense of conflicts — it’s pretty clear now that users won’t download both apps, they’ll get either one or the other — but was instead referring to one app being considered a version of the other. To clarify, in my latest comment I was referring to the concern I had in the comment prior to it, which is a concern I no longer have after @rolandwalker’s input. Does that make sense? In sum, all four casks should remain, and yes, a comment would likely help. Something small like “The download url was discovered by sniffing Xamarin’s traffic”, it doesn’t need to be a full-fledged set of instructions. |
OK, I'll remove the commit to remove the |
I just realised that including the manifest URL would be ideal, so the comment now includes the URL which can be parsed to determine the download links. |
Even better. That was exactly what @rolandwalker was referring to. Those can be added as appcasts. Instead of # http://xamarin.com/installer_assets/v3/Mac/Universal/InstallationManifest.xml
url 'http://download.xamarin.com/MonoforAndroid/Mac/mono-android-4.12.5-2.pkg'
homepage 'http://xamarin.com/android' we can have url 'http://download.xamarin.com/MonoforAndroid/Mac/mono-android-4.12.5-2.pkg'
# non-Sparkle appcast
appcast 'http://xamarin.com/installer_assets/v3/Mac/Universal/InstallationManifest.xml'
homepage 'http://xamarin.com/android'
|
#4847 has been merged, so should I append Also, should I remove the "Discovered by sniffing the web traffic of the official Xamarin installer" comment above the URL now that it will live in the |
Yes, I believe you’re right on both accounts. The comment can go, and |
#4847 has been merged but not released, so most users don't have the code to support it. A comment is the best way, for the moment. @jamesottaway, it is generous of you to work out all these details. Greatly appreciated here. |
Ah, of course. I'll put the Should be good to go now! |
Thank you for all your work on this. And thank you as well, @Fapper. Merged. |
Restore Xamarin Studio, as well as the Android and iOS platforms
#5099 (and later #5118) removed these three Casks because it was believed they couldn't be updated.
This isn't the case, so this PR restores the three individual Casks to allow direct installing of Xamarin Studio along with Xamarin.Android and Xamarin.iOS.
For the record, I use Charles (a web debugging proxy) to retrieve the direct download URLs for these three packages out of the general installer which Xamarin offer.
If any of this is unclear I'd be happy to clarify why I believe these Casks are the correct approach rather than the
Xamarin
one added in that other PR.