Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sketchup to v2014 and add sketchupviewer #5090

Merged
merged 1 commit into from
Jun 29, 2014
Merged

update sketchup to v2014 and add sketchupviewer #5090

merged 1 commit into from
Jun 29, 2014

Conversation

jconley
Copy link
Contributor

@jconley jconley commented Jun 27, 2014

sketchup has 3 products, make, pro and viewer
see http://www.sketchup.com/download/all
update to latest 2014 version
add sketchupviewer cask
sketchup-pro will be added to the versions repo

@rolandwalker
Copy link
Contributor

Hi! The contributions are much appreciated!

We do want these updates, but probably want to organize them a little differently. The app name is still SketchUp.app, so according to our naming conventions, the Cask is still named sketchup.app. (There is a script to generate the name at ./developer/bin/cask_namer, and a document at CASK_NAMING_REFERENCE.md.

The Pro version is an alternate version of the same app, so it should be submitted to the versions repo.

The SketchUpViewer.app submission is a welcome addition. However, it should be renamed to sketchupviewer.rb with a first line reading

class Sketchupviewer < Cask

@jconley jconley changed the title update sketchup to v2014 and add all 3 sketchup product casks update sketchup to v2014 and add sketchupviewer Jun 28, 2014
@vitorgalvao
Copy link
Contributor

The comments on sketchup-pro also apply to these two casks. Would you mind making the changes?

sketchup has 3 products, make, pro and viewer
see http://www.sketchup.com/download/all
update to latest 2014 version
add sketchupviewer
pro will be added to versions repo
@jconley
Copy link
Contributor Author

jconley commented Jun 29, 2014

@rolandwalker I noticed eclipse follows my original commit pattern of sketchup-make + sketchup-pro as eclipse-ide, eclipse-java, eclipse-jee, eclipse-platform
old pattern, or is this any different?

@rolandwalker
Copy link
Contributor

@jconley, good eye, old pattern. Sorry if you copied from that. We are trying to make things more systematic/predictable.

vitorgalvao added a commit that referenced this pull request Jun 29, 2014
update sketchup to v2014 and add sketchupviewer
@vitorgalvao vitorgalvao merged commit f138654 into Homebrew:master Jun 29, 2014
@jconley jconley deleted the sketchup branch July 16, 2014 14:10
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants