Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Messenger.app version 1.1.0 #10542

Merged
merged 1 commit into from
Apr 11, 2015
Merged

Add Messenger.app version 1.1.0 #10542

merged 1 commit into from
Apr 11, 2015

Conversation

vinkla
Copy link
Contributor

@vinkla vinkla commented Apr 11, 2015

A beautiful desktop client for Facebook Messenger. http://messengerfordesktop.com/

A beautiful desktop client for Facebook Messenger. http://messengerfordesktop.com/
@denpatin
Copy link
Contributor

I am not sure whether it is a common practice to include the name of the developer app to the cask name. If to consult the website for this app, you will not see there any combination of Aluxian Messenger. It is either Facebook Messenger or Messenger for Desktop or simply Messenger. So I propose that both the cask name and app name parameter are as I have indicated in the previous sentence.

@alebcay
Copy link
Member

alebcay commented Apr 11, 2015

Indeed, prefixing the developer name is uncommon, but the name messenger is already taken. In the case of token collisions, we follow the proposal from #3344, which is to prepend the vendor name. Specifically, we've had so many Facebook Messenger apps in the past few days that an issue for those specifically has appeared in #10539.

alebcay added a commit that referenced this pull request Apr 11, 2015
Add Messenger.app version 1.1.0
@alebcay alebcay merged commit db8b575 into Homebrew:master Apr 11, 2015
@vinkla
Copy link
Contributor Author

vinkla commented Apr 11, 2015

Thanks!

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants