Skip to content

Token Collision #10539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vinkla opened this issue Apr 11, 2015 · 2 comments
Closed

Token Collision #10539

vinkla opened this issue Apr 11, 2015 · 2 comments

Comments

@vinkla
Copy link
Contributor

vinkla commented Apr 11, 2015

Since Facebook announced the website version of messenger there has been a lot of new Mac integrations. Now we've a problem. This new Messenger for mac has the same name as an existing cask. I'm curious, how do we deal with this? Should we rename them both or should we just skip this new one?
@tapeinosyne
Copy link
Contributor

It is a good thing you found and contributed many such apps, thus noticing the collision.

Our current convention is to prefix the new token with the name of the developer, as described in the token reference:

If the result conflicts with the name of an existing Cask, make yours unique by prepending the name of the vendor or developer, followed by a hyphen. Example: unison.rb and panic-unison.rb.

@vinkla
Copy link
Contributor Author

vinkla commented Apr 11, 2015

Great. Then I know for future PRs. Thanks!

@vinkla vinkla closed this as completed Apr 11, 2015
@alebcay alebcay mentioned this issue Apr 11, 2015
Merged
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vinkla @tapeinosyne