Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make note of --describe option to dump in readme #372

Merged
merged 1 commit into from
Oct 2, 2018
Merged

make note of --describe option to dump in readme #372

merged 1 commit into from
Oct 2, 2018

Conversation

phallstrom
Copy link
Contributor

No description provided.

@phallstrom phallstrom mentioned this pull request Oct 1, 2018
Closed
colindean
colindean approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@colindean colindean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I can't believe we missed that!

@colindean
Copy link
Member

Blah, CI is failing because rubocop config changed in the meantime.

@colindean colindean mentioned this pull request Oct 2, 2018
Merged
@colindean
Copy link
Member

Rebase once #373 is merged!

@colindean colindean self-assigned this Oct 2, 2018
@colindean
Copy link
Member

You can rebase now!

@phallstrom
Copy link
Contributor Author

rebased!

@colindean colindean merged commit 09b6522 into Homebrew:master Oct 2, 2018
@MikeMcQuaid
Copy link
Member

Great work, thanks!

@lock lock bot added the outdated label Jan 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@colindean colindean colindean approved these changes

Assignees

@colindean colindean

Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phallstrom @colindean @MikeMcQuaid