Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade the json gem from 1.8.3 to 1.8.6 to get ruby >=2.4 support #371

Closed
wants to merge 1 commit into from

Conversation

phallstrom
Copy link
Contributor

Version 1.8.3 of the json gem isn't compatable with ruby 2.4 and later.
see: ruby/json#303

Specifically require the json gem to ensure we fetch a compatible
version.

Version 1.8.3 of the json gem isn't compatable with ruby 2.4 and later.
see: ruby/json#303

Specifically require the json gem to ensure we fetch a compatible
version.
@colindean
Copy link
Member

What problem did you encounter in brew bundle that led you to submit this?

@phallstrom
Copy link
Contributor Author

I was going to resurrect my work from #297 and was unable to install/run tests locally on a fresh copy of master.

@colindean
Copy link
Member

Some time has passed since then. brew bundle dump --describe does what #297 would do now. Try it out!

@phallstrom
Copy link
Contributor Author

Well, look at that :) In that case... consider #372

@colindean
Copy link
Member

This is now obsolete, #372 documented --describe, which was the intent of #297, and this PR was driving toward that while building brew on Ruby 2.4.

@colindean colindean closed this Oct 2, 2018
@phallstrom
Copy link
Contributor Author

Not sure this is obsolete... I still can't bundle install if I check out this repo.

@colindean
Copy link
Member

@phallstrom Let's handle that as a separate bug issue.

@phallstrom
Copy link
Contributor Author

@colindean separate issue? Not sure I understand.. this PR does nothing but update the gem version which is necessary to install it with ruby >= 2.4

@MikeMcQuaid
Copy link
Member

brew bundle does not use Ruby 2.4 or bundle install at runtime. Adjust your local ruby version accordingly if you're having trouble running rake with this repository for development.

@phallstrom
Copy link
Contributor Author

🤦 I just went to verify this and I don't know how, but the version I was checking against was really really old. Sorry for the noise.

@phallstrom phallstrom deleted the upgrade-json-gem branch October 2, 2018 20:20
@MikeMcQuaid
Copy link
Member

@phallstrom No worries!

@lock lock bot added the outdated label Jan 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants