-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade the json gem from 1.8.3 to 1.8.6 to get ruby >=2.4 support #371
Conversation
Version 1.8.3 of the json gem isn't compatable with ruby 2.4 and later. see: ruby/json#303 Specifically require the json gem to ensure we fetch a compatible version.
What problem did you encounter in |
I was going to resurrect my work from #297 and was unable to install/run tests locally on a fresh copy of master. |
Some time has passed since then. |
Well, look at that :) In that case... consider #372 |
Not sure this is obsolete... I still can't |
@phallstrom Let's handle that as a separate bug issue. |
@colindean separate issue? Not sure I understand.. this PR does nothing but update the gem version which is necessary to install it with ruby >= 2.4 |
|
🤦 I just went to verify this and I don't know how, but the version I was checking against was really really old. Sorry for the noise. |
@phallstrom No worries! |
Version 1.8.3 of the json gem isn't compatable with ruby 2.4 and later.
see: ruby/json#303
Specifically require the json gem to ensure we fetch a compatible
version.