Skip to content

Revert "tap: fix autobump logic for unofficial taps" #19920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bevanjkay wants to merge 1 commit into from
Closed

Revert "tap: fix autobump logic for unofficial taps" #19920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Library/Homebrew/tap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,10 +987,8 @@ def self.tap_migration_oldnames(current_tap, name_or_token)
def autobump
autobump_packages = if core_cask_tap?
Homebrew::API::Cask.all_casks
elsif core_tap?
Homebrew::API::Formula.all_formulae
else
{}
Homebrew::API::Formula.all_formulae
end

@autobump ||= autobump_packages.select do |_, p|
Expand Down
3 changes: 1 addition & 2 deletions Library/Homebrew/tap_auditor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
@tap_style_exceptions = tap.style_exceptions
@tap_pypi_formula_mappings = tap.pypi_formula_mappings
@tap_autobump = tap.autobump
@tap_official = tap.official?
@problems = []

@cask_tokens = tap.cask_tokens.map do |cask_token|
Expand Down Expand Up @@ -55,8 +54,8 @@
check_formula_list_directory "audit_exceptions", @tap_audit_exceptions
check_formula_list_directory "style_exceptions", @tap_style_exceptions
check_formula_list "pypi_formula_mappings", @tap_pypi_formula_mappings
check_formula_list ".github/autobump.txt", @tap_autobump

Check warning on line 57 in Library/Homebrew/tap_auditor.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/tap_auditor.rb#L57 

Added line #L57 was not covered by tests
check_formula_list "formula_renames", @formula_renames.values
check_formula_list ".github/autobump.txt", @tap_autobump unless @tap_official
end

sig { void }
Expand Down
Loading