Skip to content

Revert "tap: fix autobump logic for unofficial taps"#19920

Closed
bevanjkay wants to merge 1 commit intomasterfrom
revert-19854-autobump-fix
Closed

Revert "tap: fix autobump logic for unofficial taps"#19920
bevanjkay wants to merge 1 commit intomasterfrom
revert-19854-autobump-fix

Conversation

@bevanjkay
Copy link
Member

Reverts #19854

See #19919

@bevanjkay
Copy link
Member Author

After this is merged, #19786 should also be reverted.

@botantony
Copy link
Member

Maybe it'd be better to keep changes in formula/cask DSL and just modify autobump method in tap.rb? This is the only part that causes the issues by far, removing Homebrew API request reverts autobump behavior (i.e. it only bumps packages in autobump.txt) and allows to use no_autobump! method in formulae/casks (and adjust how it works).

P.S. this is what I was worrying about in the original PR #19786 (comment)
I do not blame anyone for not responding me, but for the next time it'd be better if more contributors provided their feedback

@Bo98
Copy link
Member

Bo98 commented May 10, 2025

I think this is handled now.

@Bo98 Bo98 closed this May 10, 2025
@MikeMcQuaid MikeMcQuaid deleted the revert-19854-autobump-fix branch June 11, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants