Skip to content

formula_auditor: fix false negatives in audit_gcc_dependency #13918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlocab merged 1 commit into from
Sep 22, 2022
Merged

formula_auditor: fix false negatives in audit_gcc_dependency #13918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Library/Homebrew/formula_auditor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,8 +892,9 @@ def linux_only_gcc_dep?(formula)
# This variation either:
# 1. does not exist
# 2. has no variation-specific dependencies
# In either case, it matches Linux.
return false if variation_dependencies.blank?
# In either case, it matches Linux. We must check for `nil` because an empty
# array indicates that this variation does not depend on GCC.
return false if variation_dependencies.nil?
# We found a non-Linux variation that depends on GCC.
return false if variation_dependencies.include?("gcc")
end
Expand Down