formula_auditor: fix false negatives in audit_gcc_dependency#13918
Merged
carlocab merged 1 commit intoHomebrew:masterfrom Sep 22, 2022
carlocab:fix_gcc_dependency
Merged
formula_auditor: fix false negatives in audit_gcc_dependency#13918carlocab merged 1 commit intoHomebrew:masterfrom carlocab:fix_gcc_dependency
audit_gcc_dependency#13918carlocab merged 1 commit intoHomebrew:masterfrom
carlocab:fix_gcc_dependency
Conversation
This audit is mistakenly passing for formulae where `variations_dependencies` is an empty array. We can fix that by checking for `nil` instead. See Homebrew/homebrew-core#111280.
Contributor
|
Review period skipped due to |
BrewTestBot
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This audit is mistakenly passing for formulae where
variations_dependenciesis an empty array. We can fix that by checkingfor
nilinstead.See Homebrew/homebrew-core#111280.