Skip to content

rubocops/lines: check allowlist for use of ENV.runtime_cpu_detection #11637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeMcQuaid merged 1 commit into from
Jul 2, 2021
Merged

rubocops/lines: check allowlist for use of ENV.runtime_cpu_detection #11637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Library/Homebrew/rubocops/lines.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,13 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node)
problem "macOS has been 64-bit only since 10.6 so ENV.universal_binary is deprecated."
end

find_instance_method_call(body_node, "ENV", :runtime_cpu_detection) do
next if tap_style_exception? :runtime_cpu_detection_allowlist

problem "Formulae should be verified as having support for runtime hardware detection before " \
"using ENV.runtime_cpu_detection."
end

find_every_method_call_by_name(body_node, :depends_on).each do |method|
next unless method_called?(method, :new)

Expand Down