rubocops/lines: check allowlist for use of ENV.runtime_cpu_detection#11637
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Jul 2, 2021
carlocab:runtime-cpu-allowlist
Merged
rubocops/lines: check allowlist for use of ENV.runtime_cpu_detection#11637MikeMcQuaid merged 1 commit intoHomebrew:masterfrom carlocab:runtime-cpu-allowlist
ENV.runtime_cpu_detection#11637MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
carlocab:runtime-cpu-allowlist
Conversation
This is implements the first audit discussed in #11608.
Contributor
|
Review period will end on 2021-07-02 at 17:53:37 UTC. |
MikeMcQuaid
approved these changes
Jul 2, 2021
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Perfect, thanks @carlocab!
Contributor
|
Review period skipped due to |
BrewTestBot
approved these changes
Jul 2, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?(In progress... will update this when it's done.)This is implements the first audit discussed in #11608. (Second audit is in progress.)