Skip to content

rubocops/lines: check allowlist for use of ENV.runtime_cpu_detection#11637

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
carlocab:runtime-cpu-allowlist
Jul 2, 2021
Merged

rubocops/lines: check allowlist for use of ENV.runtime_cpu_detection#11637
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
carlocab:runtime-cpu-allowlist

Conversation

@carlocab
Copy link
Member

@carlocab carlocab commented Jul 1, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally? (In progress... will update this when it's done.)

This is implements the first audit discussed in #11608. (Second audit is in progress.)

This is implements the first audit discussed in #11608.
@BrewTestBot
Copy link
Contributor

Review period will end on 2021-07-02 at 17:53:37 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 1, 2021
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @carlocab!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jul 2, 2021
@MikeMcQuaid MikeMcQuaid enabled auto-merge July 2, 2021 12:52
@BrewTestBot
Copy link
Contributor

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 2, 2021
@MikeMcQuaid MikeMcQuaid merged commit 83aa3ff into Homebrew:master Jul 2, 2021
@carlocab carlocab deleted the runtime-cpu-allowlist branch July 2, 2021 12:58
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments