Conversation
|
|
Rutam21
changed the title
Author
|
@aantn Please review and suggest changes, if any. Thanks. |
Collaborator
|
Hey, thank you for the PR! Right now we're trying to keep the examples to read-only commands only, and not commands that have side-effects or impact the environment. (This is for safety reasons as the parameters are LLM controlled.) I do want to add support for executing commands with side effects, subject to user approval. But for now, I'm going to hold on merging this. We need to do more work on our side first. (Would you be open to sharing these examples in a separate repo though?) |
Author
|
@aantn Sure, Just point me out to the correct repository and I can add a PR there and close this, |
Collaborator
Collaborator
|
Closing here but please open that PR on the other repo! |
goyamegh
added a commit
to goyamegh/holmesgpt
that referenced
this pull request
Mar 9, 2026
- Rename OTEL_AWS_SERVICE → HOLMES_AWS_OSIS_SERVICE with backwards-compat fallback (Comment HolmesGPT#10, svrnm) - Align OTEL_DEBUG with OTEL spec OTEL_LOG_LEVEL=debug with backwards-compat fallback (Comment HolmesGPT#9, svrnm) - Add ml-commons AgentTracer.java GitHub permalink (Comment HolmesGPT#3, kylehounslow) - Document needs_aws_auth() as single source of truth with consumer list (Comment HolmesGPT#4, kylehounslow) - Clarify otel_logging.py: logs NOT exported via OTLP, naming avoids shadowing builtin logging (Comment HolmesGPT#5, kylehounslow) - Explain experimental/ placement: API evolving, removable via try/except no-op fallbacks (Comment HolmesGPT#6, kylehounslow) - Clarify server.py middleware: tracing/metrics init in init_otel() above, middleware only handles per-request spans (Comment HolmesGPT#7, kylehounslow) - Split env var docs into Standard OTEL / Holmes-Specific tables, add missing vars, add OSIS hyperlink (Comments HolmesGPT#1, HolmesGPT#9, HolmesGPT#10) - Fix no-op tracer fallback in server-agui.py for when OTEL is unavailable Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Megha Goyal <goyamegh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to add new custom toolsets to the HolmesGPT example showcase. Toolsets comprise of Docker, Kubernetes, and Helm categories. Each toolset is added as an individual
yamlfile.List of Toolsets Added
Docker Toolsets
Kubernetes Toolsets
Helm Toolsets
Additional Information
This is a part of @aantn's Twitter challenge.