Added a new toolset to HolmesGPT - #7
Closed
adithyapaib wants to merge 2 commits into
Closed
adithyapaib wants to merge 2 commits into
adithyapaib wants to merge 2 commits into
Conversation
and a toolset to query Jaeger traces
|
|
Collaborator
|
Hey, thank you for contributing! There are two issues we need to resolve before merging:
(a) Query Jaeger's query dependency graph (see here) so that you can ask questions like (b) Allow querying a list of all Jaeger services and then traces for that service - see here for example
|
Collaborator
|
Hey, I'm closing this for now but please feel free to re-open after addressing the comments above! |
goyamegh
added a commit
to goyamegh/holmesgpt
that referenced
this pull request
Mar 9, 2026
- Rename OTEL_AWS_SERVICE → HOLMES_AWS_OSIS_SERVICE with backwards-compat fallback (Comment HolmesGPT#10, svrnm) - Align OTEL_DEBUG with OTEL spec OTEL_LOG_LEVEL=debug with backwards-compat fallback (Comment HolmesGPT#9, svrnm) - Add ml-commons AgentTracer.java GitHub permalink (Comment HolmesGPT#3, kylehounslow) - Document needs_aws_auth() as single source of truth with consumer list (Comment HolmesGPT#4, kylehounslow) - Clarify otel_logging.py: logs NOT exported via OTLP, naming avoids shadowing builtin logging (Comment HolmesGPT#5, kylehounslow) - Explain experimental/ placement: API evolving, removable via try/except no-op fallbacks (Comment HolmesGPT#6, kylehounslow) - Clarify server.py middleware: tracing/metrics init in init_otel() above, middleware only handles per-request spans (Comment HolmesGPT#7, kylehounslow) - Split env var docs into Standard OTEL / Holmes-Specific tables, add missing vars, add OSIS hyperlink (Comments HolmesGPT#1, HolmesGPT#9, HolmesGPT#10) - Fix no-op tracer fallback in server-agui.py for when OTEL is unavailable Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Megha Goyal <goyamegh@amazon.com>
aantn
pushed a commit
that referenced
this pull request
Mar 21, 2026
Address 5 CodeRabbit review comments from PR #1811: Issue #3 - Cache key inadequacy: create_tool_executor now stores a cache key (tags, enable_all) alongside the executor and validates it on cache hit. Callers with different parameters get a fresh executor. Issue #4/#5 - Change detection misses added/removed toolsets: refresh_toolsets_and_get_changes now compares name sets between old and new toolset lists, reporting additions and removals alongside status transitions. refresh_tool_executor always updates the cached executor (not just when status changes exist). Issue #6 - Race condition: Added threading.Lock around all reads and writes of _cached_tool_executor. Added Config.cached_tool_executor property for thread-safe external access. Updated server.py to use it. Issue #7 - Cold-cache refresh: refresh_tool_executor now uses FORCE_REFRESH on cold start instead of ENABLED, ensuring live prerequisite checks rather than stale disk cache. https://claude.ai/code/session_01Qr7wtBgYGnh1G6Bq2wPp79 Signed-off-by: Claude <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following Toolsets