Repository navigation
Update permissions.md - #751
Conversation
WalkthroughThe documentation for configuring permissions in HolmesGPT was updated to clarify that the instructions are specific to Kubernetes deployments via Helm. The guide now separates steps for the standalone Holmes Helm Chart and the Robusta Helm Chart, providing tailored, chart-specific instructions for each scenario. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/data-sources/permissions.md (3)
3-4: Add cross-link to CLI permissions page
The admonition clarifies scope, but a direct link to the section covering local/CLI permissions would save readers a search step and reinforce the doc hierarchy.
23-34: Use an idempotent Helm command (upgrade --install) and show namespace flags
Many users copy-paste these snippets into fresh clusters where the release may not yet exist. Adding--installplus a namespace example makes the command safe and self-contained.-helm upgrade holmes holmes/holmes --values=values.yaml +helm upgrade --install holmes holmes/holmes \ + --namespace holmes --create-namespace \ + --values=values.yaml
49-52: Mirror the idempotent pattern for the Robusta chart-helm upgrade robusta robusta/robusta --values=generated_values.yaml --set clusterName=<YOUR_CLUSTER_NAME> +helm upgrade --install robusta robusta/robusta \ + --namespace robusta --create-namespace \ + --values=generated_values.yaml \ + --set clusterName=<YOUR_CLUSTER_NAME>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/data-sources/permissions.md(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: robusta-dev/holmesgpt#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-27T14:10:31.590Z
Learning: RBAC permissions are respected for Kubernetes access
Learnt from: nherment
PR: robusta-dev/holmesgpt#408
File: holmes/plugins/toolsets/kubernetes_logs.py:90-97
Timestamp: 2025-05-15T05:13:43.169Z
Learning: In the Kubernetes logs toolset for Holmes, both current and previous logs are intentionally fetched and combined for each pod, even though this requires more API calls. This design ensures all logs are captured even when pods restart but retain their name, providing complete diagnostic information.
docs/data-sources/permissions.md (1)
Learnt from: CR
PR: robusta-dev/holmesgpt#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-27T14:10:31.590Z
Learning: RBAC permissions are respected for Kubernetes access
🪛 LanguageTool
docs/data-sources/permissions.md
[style] ~2-~2: Using many exclamation marks might seem excessive (in this case: 3 exclamation marks for a text that’s 1284 characters long)
Context: ...nal Resources (In-Cluster Deployments) !!! note "In-Cluster Only" This page ap...
(EN_EXCESSIVE_EXCLAMATION)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Pre-commit checks
- GitHub Check: llm_evals
- GitHub Check: Pre-commit checks
2 participants
No description provided.