Repository navigation
[ROB-1732] Holmes able to unzip logs from findings - #731
Conversation
WalkthroughTwo new methods, Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant SupabaseDal
Caller->>SupabaseDal: get_issue_data(...)
SupabaseDal->>SupabaseDal: extract_relevant_issues(evidence)
alt enrichment_type == "text_file"
SupabaseDal->>SupabaseDal: unzip_evidence_file(data)
end
SupabaseDal-->>Caller: filtered and decompressed evidence
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📥 CommitsReviewing files that changed from the base of the PR and between d83389f1fd6d123a7d8be9eedcaf6ce3be18c96d and 94ff124. 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.py📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
🪛 Ruff (0.12.2)holmes/core/supabase_dal.py308-311: Combine Combine (SIM114) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
holmes/core/supabase_dal.py(4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py
📄 CodeRabbit Inference Engine (CLAUDE.md)
**/*.py: Use Ruff for formatting and linting (configured in pyproject.toml)
Type hints required (mypy configuration in pyproject.toml)
Files:
holmes/core/supabase_dal.py
🧠 Learnings (1)
📓 Common learnings
Learnt from: nherment
PR: robusta-dev/holmesgpt#408
File: holmes/plugins/toolsets/kubernetes_logs.py:90-97
Timestamp: 2025-05-15T05:13:43.169Z
Learning: In the Kubernetes logs toolset for Holmes, both current and previous logs are intentionally fetched and combined for each pod, even though this requires more API calls. This design ensures all logs are captured even when pods restart but retain their name, providing complete diagnostic information.
🪛 Ruff (0.12.2)
holmes/core/supabase_dal.py
308-311: Combine if branches using logical or operator
Combine if branches
(SIM114)
🪛 GitHub Actions: Build and test HolmesGPT
holmes/core/supabase_dal.py
[error] 311-311: ruff-format: File was reformatted due to code style issues (e.g., changed single quotes to double quotes). Run 'ruff --fix' to apply formatting.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: llm_evals
- GitHub Check: Pre-commit checks
🔇 Additional comments (2)
holmes/core/supabase_dal.py (2)
10-10: LGTM!The
gzipimport is correctly placed and necessary for the new decompression functionality.
371-371: LGTM!Good refactoring that centralizes evidence filtering and decompression logic, improving code maintainability.
d83389f to
3d9d792
Compare
2 participants
Here we see holmes prints log data with only the logs from finding
Here you can see the unzipped logs
here is the PR where files were removed due to them being zipped
#106