Repository navigation
Main 1907 workload health endpoint - #106
Merged
Merged
Conversation
|
|
arikalon1
approved these changes
Aug 11, 2024
arikalon1
left a comment
arikalon1
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, left a minor comment
| ) | ||
| issue_data["evidence"] = evidence.data | ||
| return issue_data No newline at end of file | ||
| enrichment_blacklist = {"text_file", "alert_labels", "ai_analysis", "holmes"} |
Collaborator
There was a problem hiding this comment.
Why are you also removing the alert labels? and text files?
Collaborator
Author
There was a problem hiding this comment.
text files are zipped and require some extra work. also the logs are taken in the investigation so it seems redundant.
alert labels just not sure how useful they are
| .execute() | ||
| ) | ||
|
|
||
| enrichment_blacklist = {"text_file", "alert_labels", "ai_analysis", "holmes"} |
Avi-Robusta
added a commit
that referenced
this pull request
Jul 29, 2025
Here we see holmes prints log data with only the logs from finding <img width="343" height="450" alt="Screenshot 2025-07-28 at 10 01 01" src="https://github.com/user-attachments/assets/049489a4-5c27-41aa-80ad-fcc062b8fa5f" /> Here you can see the unzipped logs <img width="663" height="348" alt="Screenshot 2025-07-28 at 10 01 20" src="https://github.com/user-attachments/assets/9b084cb7-e2b0-420f-867b-b3cc84c43de7" /> here is the PR where files were removed due to them being zipped #106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.