ROB-3020 shorten mock file names to avoid errors. revert git command change - #1375
Conversation
Signed-off-by: Roi Glinik <groi.tech@gmail.com>
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Results of HolmesGPT evalsAutomatically triggered by commit 35af208 on branch Results of HolmesGPT evals
Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%. Historical Comparison DetailsFilter: excluding branch 'ROB-3020-shorten-mock-files-names' Status: Success - 21 test/model combinations loaded Experiments compared (30):
Comparison indicators:
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line): Run evals on a different branch (e.g., master) for comparison:
Quick re-run: Use Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
Commands: CLI: |
WalkthroughThe pull request removes a Windows-specific Git configuration step from the build workflow and deletes multiple obsolete New Relic NRQL query test fixtures while adding a new TCP connectivity check test fixture. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:28a1e79
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:28a1e79 me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:28a1e79
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:28a1e79Patch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:28a1e79Robusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:28a1e79 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@tests/llm/fixtures/test_ask_holmes/124b_new_relic_multi_account_alert_prompt/tcp_checkprometheus-server.default.svc.cluster.local_9090.txt`:
- Around line 1-3: The filename is missing an underscore between the tool name
and host; rename the file from
tcp_checkprometheus-server.default.svc.cluster.local_9090.txt to
tcp_check_prometheus-server.default.svc.cluster.local_9090.txt so it follows the
directory naming convention (matching other fixtures like
newrelic_execute_nrql_query6358011_Prometheus_pod_logs.txt); update any
references to this filename in tests or fixtures (search for
tcp_checkprometheus-server.default.svc.cluster.local_9090) to use the new name.
…change (#1375) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Removed multiple outdated test fixtures for New Relic NRQL query operations, including queries for crashpod logs, Prometheus logs, and related infrastructure data * Added test fixture for TCP connectivity checks against Prometheus server * **Chores** * Updated CI/CD workflow configuration to streamline Windows build process <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Roi Glinik <groi.tech@gmail.com>
Summary by CodeRabbit
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.