Skip to content

ROB-3020 add long file name support in windows - #1368

Merged
RoiGlinik merged 2 commits into
masterfrom
ROB-3020-windows-build-failed
Jan 18, 2026
Merged

RoiGlinik merged 2 commits into
masterfrom
ROB-3020-windows-build-failed

Conversation

@RoiGlinik

@RoiGlinik RoiGlinik commented Jan 15, 2026 •

Copy link
Copy Markdown
Collaborator

attempt to fix failing windows builds

Summary by CodeRabbit

  • Chores
    • Improved Windows build system compatibility by enabling long file path support in Git configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Roi Glinik <groi.tech@gmail.com>
@netlify

netlify Bot commented Jan 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for holmes-docs ready!

Name Link
🔨 Latest commit 7c35c51
🔍 Latest deploy log https://app.netlify.com/projects/holmes-docs/deploys/696ce5557355d90008447f50
😎 Deploy Preview https://deploy-preview-1368--holmes-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jan 15, 2026 •

Copy link
Copy Markdown
Contributor

✅ Docker image ready for c80604b (built in 5m 23s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:c80604b
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:c80604b me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:c80604b
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:c80604b

Patch Helm values in one line (choose the chart you use):

HolmesGPT chart:

helm upgrade --install holmesgpt ./helm/holmes \
  --set registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set image=holmes-dev:c80604b

Robusta wrapper chart:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set holmes.image=holmes-dev:c80604b

@coderabbitai

coderabbitai Bot commented Jan 15, 2026 •

Copy link
Copy Markdown
Contributor

Walkthrough

Adds a Windows-specific Git configuration step to the build workflow to enable support for long file paths by setting core.longpaths to true in the "Install dependencies" job.

Changes

Cohort / File(s) Summary
Git Configuration for Long Paths Support
/.github/workflows/build-binaries-and-brew.yaml
Adds single step to configure Git for Windows to support long file paths via git config --system core.longpaths true

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • arikalon1
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding Windows support for long file paths, which directly matches the single-line Git config addition in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


🧹 Recent nitpick comments
.github/workflows/build-binaries-and-brew.yaml (1)

37-37: Good fix for enabling long paths, but placement may need adjustment.

If the build failure occurs during the actions/checkout step (line 19), this configuration won't help since it's applied afterward. You may need to add a separate step before checkout to configure long paths:

- name: Enable long paths on Windows
  if: matrix.os == 'windows-latest'
  run: git config --system core.longpaths true

Also consider using --global instead of --system — it doesn't require admin privileges and is sufficient for CI workflows.

Please verify where the Windows build is actually failing (checkout vs. dependency installation). If it's during checkout, the config needs to be moved earlier in the workflow.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a749b59 and 973f8f7.

📒 Files selected for processing (1)
  • .github/workflows/build-binaries-and-brew.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: build
  • GitHub Check: build (3.10)
  • GitHub Check: build (3.11)
  • GitHub Check: llm_evals
  • GitHub Check: build (3.12)

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jan 15, 2026 •

Copy link
Copy Markdown
Contributor

📂 Previous Runs

📜 Run @ 973f8f7 (#21032925581)

✅ Results of HolmesGPT evals

Automatically triggered by commit 973f8f7 on branch ROB-3020-windows-build-failed

View workflow logs

Results of HolmesGPT evals

  • ask_holmes: 9/9 test cases were successful, 0 regressions
Status Test case Time Turns Tools Cost
✅ 09_crashpod 28.6s ↓16% 5 12 $0.1561
✅ 101_loki_historical_logs_pod_deleted 65.7s ↑27% 10 21 $0.2801
✅ 111_pod_names_contain_service 43.8s ↑14% 8 18 $0.1881
✅ 12_job_crashing 51.6s ±0% 10 18 $0.2214
✅ 162_get_runbooks 51.1s ±0% 8 16 $0.2246
✅ 176_network_policy_blocking_traffic_no_runbooks 42.0s ±0% 7 16 $0.1884
✅ 24_misconfigured_pvc 41.6s ↑13% 7 18 $0.1856
✅ 43_current_datetime_from_prompt 3.3s ±0% 1 — $0.0618
✅ 61_exact_match_counting 11.0s ±0% 3 3 $0.0859
Total 37.6s avg 6.6 avg 15.2 avg $1.5920

Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%.

Historical Comparison Details

Filter: excluding branch 'ROB-3020-windows-build-failed'

Status: Success - 12 test/model combinations loaded

Experiments compared (30):

Comparison indicators:

  • ±0% — diff under 10% (within noise threshold)
  • ↑N%/↓N% — diff 10-25%
  • ↑N%/↓N% — diff over 25% (significant)

✅ Results of HolmesGPT evals

Automatically triggered by commit 7c35c51 on branch ROB-3020-windows-build-failed

View workflow logs

Results of HolmesGPT evals

  • ask_holmes: 9/9 test cases were successful, 0 regressions
Status Test case Time Turns Tools Cost
✅ 09_crashpod 31.9s ±0% 6 13 $0.1669
✅ 101_loki_historical_logs_pod_deleted 55.9s ±0% 10 18 $0.2355
✅ 111_pod_names_contain_service 35.6s ±0% 7 14 $0.1714
✅ 12_job_crashing 43.3s ±0% 8 18 $0.2119
✅ 162_get_runbooks 50.6s ↑15% 8 16 $0.2399
✅ 176_network_policy_blocking_traffic_no_runbooks 40.0s ↑13% 7 17 $0.1837
✅ 24_misconfigured_pvc 36.3s ±0% 7 17 $0.1837
✅ 43_current_datetime_from_prompt 3.0s ±0% 1 — $0.0618
✅ 61_exact_match_counting 10.2s ±0% 3 3 $0.0859
Total 34.1s avg 6.3 avg 14.5 avg $1.5408

Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%.

Historical Comparison Details

Filter: excluding branch 'ROB-3020-windows-build-failed'

Status: Success - 20 test/model combinations loaded

Experiments compared (30):

Comparison indicators:

  • ±0% — diff under 10% (within noise threshold)
  • ↑N%/↓N% — diff 10-25%
  • ↑N%/↓N% — diff over 25% (significant)
📖 Legend
Icon Meaning
✅ The test was successful
➖ The test was skipped
⚠️ The test failed but is known to be flaky or known to fail
🚧 The test had a setup failure (not a code regression)
🔧 The test failed due to mock data issues (not a code regression)
🚫 The test was throttled by API rate limits/overload
❌ The test failed and should be fixed before merging the PR
🔄 Re-run evals manually

⚠️ Warning: /eval comments always run using the workflow from master, not from this PR branch. If you modified the GitHub Action (e.g., added secrets or env vars), those changes won't take effect.

To test workflow changes, use the GitHub CLI or Actions UI instead:

gh workflow run eval-regression.yaml --repo HolmesGPT/holmesgpt --ref ROB-3020-windows-build-failed -f markers=regression -f filter=

Option 1: Comment on this PR with /eval:

/eval
markers: regression

Or with more options (one per line):

/eval
model: gpt-4o
markers: regression
filter: 09_crashpod
iterations: 5

Run evals on a different branch (e.g., master) for comparison:

/eval
branch: master
markers: regression
Option Description
model Model(s) to test (default: same as automatic runs)
markers Pytest markers (no default - runs all tests!)
filter Pytest -k filter (use /list to see valid eval names)
iterations Number of runs, max 10
branch Run evals on a different branch (for cross-branch comparison)

Quick re-run: Use /rerun to re-run the most recent /eval on this PR with the same parameters.

Option 2: Trigger via GitHub Actions UI → "Run workflow"

🏷️ Valid markers

benchmark, chain-of-causation, compaction, context_window, coralogix, counting, database, datadog, datetime, easy, elasticsearch, embeds, frontend, grafana-dashboard, hard, kafka, kubernetes, leaked-information, logs, loki, medium, metrics, network, newrelic, no-cicd, numerical, one-test, port-forward, prometheus, question-answer, regression, runbooks, slackbot, storage, toolset-limitation, traces, transparency


Commands: /eval · /rerun · /list

CLI: gh workflow run eval-regression.yaml --repo HolmesGPT/holmesgpt --ref ROB-3020-windows-build-failed -f markers=regression -f filter=

@RoiGlinik
RoiGlinik enabled auto-merge (squash) January 18, 2026 13:54
@RoiGlinik
RoiGlinik merged commit 8f89f31 into master Jan 18, 2026
16 of 17 checks passed
@RoiGlinik
RoiGlinik deleted the ROB-3020-windows-build-failed branch January 18, 2026 13:55
naomi-robusta pushed a commit that referenced this pull request Jan 21, 2026
Fix failing windows builds with flag to support longer file names


Signed-off-by: Roi Glinik <groi.tech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants