Skip to content

Fix oci helm push action - #1246

Merged
arikalon1 merged 1 commit into
masterfrom
fix_build
Dec 26, 2025
Merged

arikalon1 merged 1 commit into
masterfrom
fix_build

Conversation

@moshemorad

@moshemorad moshemorad commented Dec 26, 2025 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline configuration for Docker image and Helm chart deployment processes.

Note: This release contains internal infrastructure updates with no user-facing changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@moshemorad
moshemorad requested a review from arikalon1 December 26, 2025 06:43
@coderabbitai

coderabbitai Bot commented Dec 26, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

Modified the GitHub Actions workflow to push Helm charts to a fixed holmesgpt namespace in the OCI registry instead of using an owner-based registry path. All other workflow steps remain unchanged.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/build-docker-images.yaml
Updated Helm chart push destination from owner-based OCI registry path to fixed holmesgpt namespace.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • arikalon1

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix oci helm push action' directly addresses the main change in the PR: fixing the Helm chart push destination in the Docker build workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8dfac47 and fffcad9.

📒 Files selected for processing (1)
  • .github/workflows/build-docker-images.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: llm_evals
  • GitHub Check: build (3.12)
🔇 Additional comments (1)
.github/workflows/build-docker-images.yaml (1)

88-91: The hardcoded namespace oci://ghcr.io/holmesgpt/charts is correct. GHCR automatically normalizes organization names to lowercase, so holmesgpt is the expected form for the HolmesGPT organization. With the packages: write permission and proper GHCR authentication already in place, this change should work as intended.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Dec 26, 2025 •

Copy link
Copy Markdown
Contributor

✅ Docker image ready for 0f1fd00 (built in 14m 39s)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:0f1fd00
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:0f1fd00 me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:0f1fd00
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:0f1fd00

Patch Helm values in one line (choose the chart you use):

HolmesGPT chart:

helm upgrade --install holmesgpt ./helm/holmes \
  --set registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set image=holmes-dev:0f1fd00

Robusta wrapper chart:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set holmes.image=holmes-dev:0f1fd00

Signed-off-by: Mohse Morad <moshemorad12340@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Results of HolmesGPT evals

  • ask_holmes: 7/7 test cases were successful, 0 regressions
Test suite Test case Status
ask 09_crashpod ✅
ask 101_loki_historical_logs_pod_deleted ✅
ask 12_job_crashing ✅
ask 162_get_runbooks ✅
ask 176_network_policy_blocking_traffic_no_runbooks ✅
ask 43_current_datetime_from_prompt ✅
ask 61_exact_match_counting ✅

Legend

  • ✅ the test was successful
  • :minus: the test was skipped
  • ⚠️ the test failed but is known to be flaky or known to fail
  • 🚧 the test had a setup failure (not a code regression)
  • 🔧 the test failed due to mock data issues (not a code regression)
  • 🚫 the test was throttled by API rate limits/overload
  • ❌ the test failed and should be fixed before merging the PR

@arikalon1
arikalon1 merged commit bcfc05b into master Dec 26, 2025
10 of 11 checks passed
@arikalon1
arikalon1 deleted the fix_build branch December 26, 2025 07:03
FilipGrebowski pushed a commit to FilipGrebowski/holmesgpt that referenced this pull request Dec 27, 2025
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated CI/CD pipeline configuration for Docker image and Helm chart
deployment processes.

**Note:** This release contains internal infrastructure updates with no
user-facing changes.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Mohse Morad <moshemorad12340@gmail.com>
Signed-off-by: Filip Grebowski <grebowskifilip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants