helm: add oci release for charts - #1188
Conversation
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
WalkthroughThe GitHub Actions workflow is updated to add authentication to GitHub Container Registry and enable pushing Helm charts to GHCR's OCI registry. Workflow permissions are expanded to include write access to packages and id-tokens, with new docker login and helm package/push steps integrated into the build pipeline. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-docker-images.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: llm_evals
- GitHub Check: build (3.12)
- GitHub Check: build (3.10)
- GitHub Check: build (3.11)
🔇 Additional comments (2)
.github/workflows/build-docker-images.yaml (2)
12-15: LGTM! Permissions are correctly configured.The added permissions (
packages: writeandid-token: write) are appropriate for pushing Helm charts to GHCR and for the existing OIDC authentication with Google Cloud.
88-92: The Helm chart packaging and OCI registry push implementation is correctly configured. Thehelm packagecommand will generateholmes-${{github.ref_name}}.tgz, which matches the expected filename in the push command. GHCR authentication is properly set up before the push step with appropriate permissions (packages: write), and the Chart.yaml version is correctly updated during the workflow.No code-level issues identified.
arikalon1
left a comment
There was a problem hiding this comment.
Thanks for the PR @DrFaust92
Checklist for the toolset: - [ ] Toolset has unit tests where relevant - [ ] Toolset has both ask_holmes and investigate evals - [ ] Toolset has a documentation PR opened against the [robusta](https://github.com/robusta-dev/robusta) repo - [ ] Toolset has the correct is_default flag - [ ] Toolset returns a correct `get_example_config` - [ ] Toolset does a live health check in addition to checking for correct configuration - [ ] Create a demo video (if relevant) similar to robusta-dev/robusta#1954 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Enhanced deployment workflow with improved container registry integration and security enhancements for artifact distribution. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-authored-by: arik <alon.arik@gmail.com> Signed-off-by: Mohse Morad <moshemorad12340@gmail.com>
Checklist for the toolset: - [ ] Toolset has unit tests where relevant - [ ] Toolset has both ask_holmes and investigate evals - [ ] Toolset has a documentation PR opened against the [robusta](https://github.com/robusta-dev/robusta) repo - [ ] Toolset has the correct is_default flag - [ ] Toolset returns a correct `get_example_config` - [ ] Toolset does a live health check in addition to checking for correct configuration - [ ] Create a demo video (if relevant) similar to robusta-dev/robusta#1954 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Enhanced deployment workflow with improved container registry integration and security enhancements for artifact distribution. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-authored-by: arik <alon.arik@gmail.com> Signed-off-by: Filip Grebowski <grebowskifilip@gmail.com>
Checklist for the toolset:
get_example_configsimilar to robusta-dev/robusta#1954
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.