Skip to content

helm: add oci release for charts - #1188

Merged
arikalon1 merged 2 commits into
HolmesGPT:masterfrom
DrFaust92:oci
Dec 24, 2025
Merged

arikalon1 merged 2 commits into
HolmesGPT:masterfrom
DrFaust92:oci

Conversation

@DrFaust92

@DrFaust92 DrFaust92 commented Dec 12, 2025 •

Copy link
Copy Markdown
Contributor

Checklist for the toolset:

  • Toolset has unit tests where relevant
  • Toolset has both ask_holmes and investigate evals
  • Toolset has a documentation PR opened against the robusta repo
  • Toolset has the correct is_default flag
  • Toolset returns a correct get_example_config
  • Toolset does a live health check in addition to checking for correct configuration
  • Create a demo video (if relevant)

similar to robusta-dev/robusta#1954

Summary by CodeRabbit

  • Chores
    • Enhanced deployment workflow with improved container registry integration and security enhancements for artifact distribution.

✏️ Tip: You can customize this high-level summary in your review settings.

@DrFaust92 DrFaust92 changed the title add oci release for charts helm: add oci release for charts Dec 12, 2025
@DrFaust92
DrFaust92 marked this pull request as ready for review December 12, 2025 19:11
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@coderabbitai

coderabbitai Bot commented Dec 24, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

The GitHub Actions workflow is updated to add authentication to GitHub Container Registry and enable pushing Helm charts to GHCR's OCI registry. Workflow permissions are expanded to include write access to packages and id-tokens, with new docker login and helm package/push steps integrated into the build pipeline.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/build-docker-images.yaml
Added workflow permissions for packages: write and id-token: write; introduced docker login step for ghcr.io authentication; added helm package and helm push steps to deploy charts to OCI registry at ghcr.io

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • PR #964: Both PRs modify .github/workflows/build-docker-images.yaml—one adds GHCR/Helm OCI authentication and chart push, while the other updates Docker action versions and image build/push logic.

Suggested reviewers

  • moshemorad

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'helm: add oci release for charts' clearly and concisely describes the main change: adding OCI release support for Helm charts in the GitHub workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between daedf3f and 0a47d77.

📒 Files selected for processing (1)
  • .github/workflows/build-docker-images.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: llm_evals
  • GitHub Check: build (3.12)
  • GitHub Check: build (3.10)
  • GitHub Check: build (3.11)
🔇 Additional comments (2)
.github/workflows/build-docker-images.yaml (2)

12-15: LGTM! Permissions are correctly configured.

The added permissions (packages: write and id-token: write) are appropriate for pushing Helm charts to GHCR and for the existing OIDC authentication with Google Cloud.


88-92: The Helm chart packaging and OCI registry push implementation is correctly configured. The helm package command will generate holmes-${{github.ref_name}}.tgz, which matches the expected filename in the push command. GHCR authentication is properly set up before the push step with appropriate permissions (packages: write), and the Chart.yaml version is correctly updated during the workflow.

No code-level issues identified.

Comment thread .github/workflows/build-docker-images.yaml

@arikalon1 arikalon1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DrFaust92

@arikalon1
arikalon1 merged commit 507755e into HolmesGPT:master Dec 24, 2025
9 of 10 checks passed
moshemorad pushed a commit that referenced this pull request Dec 25, 2025
Checklist for the toolset:

- [ ] Toolset has unit tests where relevant
- [ ] Toolset has both ask_holmes and investigate evals
- [ ] Toolset has a documentation PR opened against the
[robusta](https://github.com/robusta-dev/robusta) repo
- [ ] Toolset has the correct is_default flag
- [ ] Toolset returns a correct `get_example_config`
- [ ] Toolset does a live health check in addition to checking for
correct configuration
- [ ] Create a demo video (if relevant)

similar to robusta-dev/robusta#1954

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Enhanced deployment workflow with improved container registry
integration and security enhancements for artifact distribution.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Co-authored-by: arik <alon.arik@gmail.com>
Signed-off-by: Mohse Morad <moshemorad12340@gmail.com>
@coderabbitai coderabbitai Bot mentioned this pull request Dec 26, 2025
FilipGrebowski pushed a commit to FilipGrebowski/holmesgpt that referenced this pull request Dec 27, 2025
Checklist for the toolset:

- [ ] Toolset has unit tests where relevant
- [ ] Toolset has both ask_holmes and investigate evals
- [ ] Toolset has a documentation PR opened against the
[robusta](https://github.com/robusta-dev/robusta) repo
- [ ] Toolset has the correct is_default flag
- [ ] Toolset returns a correct `get_example_config`
- [ ] Toolset does a live health check in addition to checking for
correct configuration
- [ ] Create a demo video (if relevant)

similar to robusta-dev/robusta#1954

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Enhanced deployment workflow with improved container registry
integration and security enhancements for artifact distribution.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Co-authored-by: arik <alon.arik@gmail.com>
Signed-off-by: Filip Grebowski <grebowskifilip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants