Release v1.14.0#417
Merged
Merged
Conversation
Release-candidate: v1.14.0
db/config.js sets bigNumberStrings: true for all environments, which
causes mysql2 to return COUNT() values as strings ("0") instead of
numbers (0). Four index-creation migrations used strict equality
(=== 0 / > 0) against that string, so the condition was always false
and the CREATE INDEX statements were silently skipped — migrations
completed and were recorded in SequelizeMeta but created no indexes.
Affected migrations:
- 20251201104138-add-tx-output-utxo-lookup-index
- 20260108100000-add-tx-output-locked-heightlock-index
- 20260108100001-add-tx-output-locked-timelock-index
- 20260108100002-add-address-tx-history-addr-voided-token-index
Fix: wrap the count value with Number() before comparing, so both
string and numeric returns are handled correctly.
Note: databases that already ran these migrations will not get the
indexes automatically (migrations won't re-run). The missing indexes
must be created manually:
CREATE INDEX idx_tx_output_utxo_lookup
ON tx_output (address, token_id, spent_by, voided, locked, authorities);
CREATE INDEX idx_tx_output_locked_heightlock
ON tx_output (locked, heightlock);
CREATE INDEX idx_tx_output_locked_timelock
ON tx_output (locked, timelock);
CREATE INDEX idx_address_tx_history_addr_voided_token
ON address_tx_history (address, voided, token_id);
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pedroferreira1
previously approved these changes
May 7, 2026
r4mmer
previously approved these changes
May 8, 2026
github-project-automation
Bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
Release-candidate: v1.14.0-rc.2
pedroferreira1
approved these changes
May 11, 2026
r4mmer
approved these changes
May 11, 2026
github-project-automation
Bot
moved this from In Review (Done)
to In Review (WIP)
in Hathor Network
github-project-automation
Bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Release-candidates
Checklist