chore: batch dependabot dependency updates#370
Merged
Conversation
Consolidates 30 dependabot PRs into a single update: Direct dependency bumps: - axios: 0.21.1 → 1.13.5 (wallet-service), 1.6.2 → 1.13.5 (daemon) - eslint: ^8.57.0 → ^9.26.0 (root) - jsonwebtoken: 8.5.1 → 9.0.0 (wallet-service) - lodash: 4.17.21 → 4.17.23 (daemon, wallet-service) - mysql2: ^3.9.3 → ^3.9.8 (root), 2.2.5 → 3.9.8 (wallet-service), 3.5.2 → 3.9.8 (daemon) - webpack: 5.88.2 → 5.104.1 (wallet-service) - ws: 8.13.0 → 8.17.1 (daemon) Transitive dependency updates via yarn.lock regeneration: qs, diff, jws, node-forge, sha.js, tar-fs, js-yaml, base-x, @babel/helpers, serialize-javascript, elliptic, cross-spawn, secp256k1, tar, jose, es5-ext, ip, @babel/traverse, validator Closes #368, #366, #365, #364, #361, #353, #348, #347, #345, #344 Closes #328, #323, #318, #316, #315, #314, #258, #220, #215, #214 Closes #197, #191, #188, #187, #157, #142, #139, #126, #124, #123 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…bot-updates # Conflicts: # yarn.lock
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdates pinned dependency versions across root and workspace package.json files and simplifies axios GET calls in the wallet-service fullnode client by removing redundant request options; a test assertion was also tightened to expect a single-argument call. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
axios 1.x no longer silently ignores `data: null` on GET requests — it serializes null as the string "null" and sends it as the request body with the `content-type: application/json` header, which the fullnode rejects. The result was txProposalCreate returning 500 in tests that rely on a real fullnode call. Removed the redundant `data: null` and content-type headers from all `.get()` calls in fullnode.ts. GETs should not carry bodies. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 24: The package.json upgrade to "eslint": "^9.26.0" is incompatible with
the currently pinned "@typescript-eslint/eslint-plugin" and
"@typescript-eslint/parser" at "^7.4.0"; update both
"@typescript-eslint/eslint-plugin" and "@typescript-eslint/parser" to a
v8-compatible range (e.g. "^8.0.0" or "^8.x") so they support ESLint 9, then run
your package manager to update the lockfile (npm/yarn/pnpm) and verify linting
passes; ensure you change the two package entries named
"@typescript-eslint/eslint-plugin" and "@typescript-eslint/parser" in
package.json accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0b3149c8-aec2-407f-95cc-a82c348e5938
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
package.jsonpackages/daemon/package.jsonpackages/wallet-service/package.jsonpackages/wallet-service/src/fullnode.ts
The axios 1.x compat fix removed the `{data: null, headers: ...}`
config object from fullnode.api.get('version'). Update the test
assertion accordingly.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks
…compat Per CodeRabbit review on this PR: root's eslint bump to ^9.26.0 left @typescript-eslint/eslint-plugin and @typescript-eslint/parser at ^7.4.0, which only supports ESLint 7/8. Bumped both to ^8.0.0. eslint-plugin-jest ^27.9.0 also pins typescript-eslint at ^5-7; bumped it to ^28.0.0 so it aligns with the typescript-eslint 8 line. Lint isn't wired into CI today, so this was warning-level (peer-dep advisories from yarn), but a future \`yarn lint\` would have failed until these ranges matched. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
andreabadesso
moved this from In Progress (WIP)
to In Progress (Done)
in Hathor Network
Removes caret ranges from the root package.json so every dep is locked to the version yarn currently resolves — no silent minor/patch drift on fresh installs. Versions taken from yarn.lock: - @typescript-eslint/eslint-plugin ^8.0.0 -> 8.58.2 - @typescript-eslint/parser ^8.0.0 -> 8.58.2 - dotenv ^16.4.5 -> 16.4.5 - eslint ^9.26.0 -> 9.39.4 - eslint-config-airbnb-base ^15.0.0 -> 15.0.0 - eslint-plugin-import ^2.29.1 -> 2.29.1 - eslint-plugin-jest ^28.0.0 -> 28.14.0 - mysql2 ^3.9.8 -> 3.22.0 - sequelize ^6.37.2 -> 6.37.2 - sequelize-cli ^6.6.2 -> 6.6.2 - typescript ^5.8.2 -> 5.8.2 - bip32 ^4.0.0 -> 4.0.0 - bitcoinjs-lib ^6.1.5 -> 6.1.5 - bitcoinjs-message ^2.2.0 -> 2.2.0 - jest ^29.7.0 -> 29.7.0 - tiny-secp256k1 ^2.2.3 -> 2.2.3 Matches the existing pinning style used for @aws-sdk/*, @hathor/wallet-lib, @wallet-service/common, and winston. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
luislhl
approved these changes
Apr 14, 2026
pedroferreira1
approved these changes
Apr 17, 2026
github-project-automation
Bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
luislhl
approved these changes
Apr 20, 2026
github-project-automation
Bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates 30 open Dependabot PRs into a single update.
Direct dependency bumps
axiosaxioseslintjsonwebtokenlodashmysql2mysql2mysql2webpackwsTransitive dependency updates (via yarn.lock regeneration)
qs,diff,jws,node-forge,sha.js,tar-fs,js-yaml,base-x,@babel/helpers,serialize-javascript,elliptic,cross-spawn,secp256k1,tar,jose,es5-ext,ip,@babel/traverse,validatorCloses Dependabot PRs
#368, #366, #365, #364, #361, #353, #348, #347, #345, #344, #328, #323, #318, #316, #315, #314, #258, #220, #215, #214, #197, #191, #188, #187, #157, #142, #139, #126, #124, #123
Test plan
axios(0.x → 1.x in wallet-service),mysql2(2.x → 3.x in wallet-service),jsonwebtoken(8.x → 9.x)Summary by CodeRabbit