fix: detecting diff error swallowing#332
Merged
andreabadesso merged 5 commits intomasterfrom Dec 23, 2025
Merged
Conversation
21e9cef to
34bc820
Compare
luislhl
previously approved these changes
Dec 16, 2025
pedroferreira1
previously approved these changes
Dec 16, 2025
3 tasks
The base branch was changed.
ff6eae6 to
1e4ba10
Compare
luislhl
approved these changes
Dec 22, 2025
pedroferreira1
approved these changes
Dec 22, 2025
This was referenced Jan 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The wallet-service-daemon got stuck in the detectingDiff state for 12+ hours on testnet-india (2025-12-15). Root cause analysis revealed that xstate silently swallows errors from invoked services when no onError handler is defined, and this behavior produces no logs in production mode (
NODE_ENV=production). The metadataDiff invoke was the only one missing an onError handler.Additionally, getDbConnection() was outside the try/catch block.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged