Merged
Conversation
andreabadesso
force-pushed
the
feat/token-creation-event
branch
from
fb0788c to
df6b3b2
Compare
andreabadesso
force-pushed
the
feat/token-creation-event
branch
from
027d3e0 to
1eac864
Compare
andreabadesso
commented
Nov 28, 2025
Comment on lines
-287
to
-293
| if (version === hathorLib.constants.CREATE_TOKEN_TX_VERSION) { | ||
| if (!token_name || !token_symbol) { | ||
| throw new Error('Processed a token creation event but it did not come with token name and symbol'); | ||
| } | ||
| await storeTokenInformation(mysql, hash, token_name, token_symbol); | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This is now done in the TOKEN_CREATED event handling
…he token_created event
andreabadesso
commented
Dec 9, 2025
| await handleVertexAccepted(context as any, {} as any); | ||
|
|
||
| expect(storeTokenInformation).toHaveBeenCalledWith(mockDb, hash, tokenName, tokenSymbol); | ||
| expect(storeTokenInformation).not.toHaveBeenCalled(); |
Collaborator
Author
There was a problem hiding this comment.
We only insert to the token info table when the TOKEN_CREATED event is received
andreabadesso
requested review from
pedroferreira1 and
r4mmer
and removed request for
pedroferreira1
andreabadesso
force-pushed
the
feat/token-creation-event
branch
2 times, most recently
from
9f6dcb0 to
2122958
Compare
andreabadesso
force-pushed
the
feat/token-creation-event
branch
from
2122958 to
2a873a8
Compare
andreabadesso
force-pushed
the
feat/token-creation-event
branch
from
deb88f6 to
611f4d3
Compare
andreabadesso
commented
Dec 17, 2025
| export const REORG_SCENARIO_PORT = 8082; | ||
| // Same as the comment on the unvoided scenario last event | ||
| export const REORG_SCENARIO_LAST_EVENT = 19; | ||
| export const REORG_SCENARIO_LAST_EVENT = 18; |
Collaborator
Author
There was a problem hiding this comment.
This is unrelated to this PR, but the simulator events changed for the reorg scenario
andreabadesso
commented
Dec 17, 2025
| }); | ||
| }); | ||
|
|
||
| describe('Error handling', () => { |
Collaborator
Author
There was a problem hiding this comment.
These tests come from #332, I cherry-picked the commit there
andreabadesso
force-pushed
the
feat/token-creation-event
branch
from
6240c55 to
764474d
Compare
pedroferreira1
approved these changes
Jan 9, 2026
r4mmer
approved these changes
Jan 9, 2026
github-project-automation
Bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
github-project-automation
Bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
This was referenced Jan 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The fullnode now emits TOKEN_CREATED events when tokens are created, either via traditional CREATE_TOKEN_TX or nano contract syscalls. The daemon needs to handle these events to properly track token creation and manage token lifecycle during reorgs and voids.
Acceptance Criteria
nc_executionchanges from success tonon-successChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged