Skip to content

fix: fullnode schema validation + nodejs 22 + incorrect fullnode #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreabadesso merged 5 commits into from
Aug 5, 2025
Merged

fix: fullnode schema validation + nodejs 22 + incorrect fullnode #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4fefff4
refactor: fullnode version schema should support min_tx_weight 0
andreabadesso Jul 30, 2025
2462e7e
chore: updated nodejs to 22
andreabadesso Jul 30, 2025
734d7c2
refactor: using positive() but added .allow(0) to allow 0
andreabadesso Aug 4, 2025
249f77f
feat: set default fullnode server as the config server
andreabadesso Aug 4, 2025
ec53f18
Merge branch 'master' into refactor/zero-tx-weight
andreabadesso Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/wallet-service/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ resources:

provider:
name: aws
runtime: nodejs18.x
runtime: nodejs22.x
region: ${opt:region, 'eu-central-1'}
# In MB. This is the memory allocated for the Lambdas, they cannot use more than this
# and will break if they try.
Expand Down
8 changes: 4 additions & 4 deletions packages/wallet-service/src/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ export const Sha256Schema = Joi.string().hex().length(64);
export const FullnodeVersionSchema = Joi.object<FullNodeApiVersionResponse>({
version: Joi.string().min(1).required(),
network: Joi.string().min(1).required(),
min_weight: Joi.number().integer().positive().required(),
min_tx_weight: Joi.number().integer().positive().required(),
min_tx_weight_coefficient: Joi.number().positive().required(),
min_tx_weight_k: Joi.number().integer().positive().required(),
min_weight: Joi.number().integer().positive().allow(0).required(),
min_tx_weight: Joi.number().integer().positive().allow(0).required(),
min_tx_weight_coefficient: Joi.number().positive().allow(0).required(),
min_tx_weight_k: Joi.number().integer().positive().allow(0).required(),
token_deposit_percentage: Joi.number().positive().required(),
reward_spend_min_blocks: Joi.number().integer().positive().required(),
max_number_inputs: Joi.number().integer().positive().required(),
Expand Down
3 changes: 2 additions & 1 deletion packages/wallet-service/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import config from '@src/config';
const bip32 = BIP32Factory(ecc);

hathorLib.network.setNetwork(config.network);
hathorLib.config.setServerUrl(config.defaultServer);

const libNetwork = hathorLib.network.getNetwork();
const hathorNetwork = {
Expand Down Expand Up @@ -254,7 +255,7 @@ export const getAddressAtIndex = (xpubkey: string, addressIndex: number): string
* @memberof Wallet
* @inner
*/
export const getAddresses = (xpubkey: string, startIndex: number, quantity: number): {[key: string]: number} => {
export const getAddresses = (xpubkey: string, startIndex: number, quantity: number): { [key: string]: number } => {
const addrMap = {};

for (let index = startIndex; index < startIndex + quantity; index++) {
Expand Down