Skip to content

fix: fullnode schema validation + nodejs 22 + incorrect fullnode#275

Merged
andreabadesso merged 5 commits intomasterfrom
refactor/zero-tx-weight
Aug 5, 2025
Merged

fix: fullnode schema validation + nodejs 22 + incorrect fullnode#275
andreabadesso merged 5 commits intomasterfrom
refactor/zero-tx-weight

Conversation

@andreabadesso
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso commented Jul 30, 2025

Motivation

  • Some networks have 0 as the min_tx_weight, we must support them.
  • Also, nodejs was set to v18 which is incompatible with our big int handling mechanism
  • Also, we had a bug where the wallet-service would not request its own fullnode for some apis

Acceptance Criteria

  • We must allow 0 for tx_weight related fullnode response validation
  • We must use nodejs v22 for the lambdas
  • We must set the fullnode url in the config singleton

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Aug 4, 2025
@andreabadesso andreabadesso added the enhancement New feature or request label Aug 4, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (WIP) in Hathor Network Aug 4, 2025
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Aug 4, 2025
@andreabadesso andreabadesso changed the title refactor: fullnode version schema should support min_tx_weight 0 fix: fullnode schema validation + nodejs 22 + incorrect fullnode Aug 4, 2025
@andreabadesso andreabadesso force-pushed the refactor/zero-tx-weight branch from 802f361 to 249f77f Compare August 5, 2025 10:42
@github-project-automation github-project-automation Bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 5, 2025
@tuliomir tuliomir moved this from In Review (WIP) to In Review (Done) in Hathor Network Aug 5, 2025
@andreabadesso andreabadesso merged commit 5fc21c9 into master Aug 5, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Aug 5, 2025
@andreabadesso andreabadesso deleted the refactor/zero-tx-weight branch August 5, 2025 17:57
This was referenced Nov 17, 2025
@andreabadesso andreabadesso moved this from Waiting to be deployed to Done in Hathor Network Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants