Skip to content

chore: testnet hotel#264

Merged
luislhl merged 1 commit intomasterfrom
chore/testnet-hotel
Jul 23, 2025
Merged

chore: testnet hotel#264
luislhl merged 1 commit intomasterfrom
chore/testnet-hotel

Conversation

@luislhl
Copy link
Copy Markdown
Collaborator

@luislhl luislhl commented Jul 15, 2025 •
edited
Loading

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Enable deploys to the new testnet-hotel

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl self-assigned this Jul 15, 2025
@luislhl luislhl moved this from Todo to In Progress (WIP) in Hathor Network Jul 15, 2025
@luislhl luislhl moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jul 16, 2025
andreabadesso
andreabadesso reviewed Jul 17, 2025
View reviewed changes
Comment thread packages/wallet-service/serverless.yml
Fn::GetAtt: [ SendNotificationToDeviceLambdaFunction , Arn ]
healthcheck:
handler: src/api/healthcheck.getHealthcheck
timeout: 20 # seconds
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Copy Markdown
Collaborator Author

@luislhl luislhl Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While checking the health of the Testnet Hotel after creating it, I received some timeouts.

It was receiving a timeout from the fullnode, but the Lambda timeout was lower than the one of the request, so the Lambda timed out without any information about the problem.

Increasing to 20s makes sure there will be a response indicating the problem (this is important even for the alerts we receive in case of failures in the healthcheck)

@luislhl luislhl requested a review from tuliomir July 17, 2025 16:39
@github-project-automation github-project-automation Bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 18, 2025
@andreabadesso andreabadesso moved this from Waiting to be deployed to In Review (Done) in Hathor Network Jul 21, 2025
@andreabadesso andreabadesso moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Jul 21, 2025
@luislhl luislhl force-pushed the chore/testnet-hotel branch from 5731945 to d5401d8 Compare July 22, 2025 16:17
@luislhl luislhl force-pushed the chore/testnet-hotel branch from d5401d8 to bf7c7ea Compare July 22, 2025 21:26
@luislhl luislhl merged commit e197b6a into master Jul 23, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 23, 2025
@luislhl luislhl deleted the chore/testnet-hotel branch July 23, 2025 15:00
r4mmer added a commit that referenced this pull request Jul 24, 2025
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/nc-events-tests
9be6f6a 
* origin/master:
  chore: testnet hotel (#264)
  feat: process nanocontract transactions and nc_addresses (#263)
This was referenced Nov 17, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuliomir tuliomir tuliomir approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@luislhl luislhl

Labels

None yet

Projects

Hathor Network
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luislhl @tuliomir @andreabadesso