Skip to content

feat: send end ACK #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4mmer merged 1 commit into from
Sep 6, 2024
Merged

feat: send end ACK #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sync/stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const QUEUE_GRACEFUL_SHUTDOWN_LIMIT = 10000;
interface IStreamSyncHistoryBegin {
type: 'stream:history:begin';
id: string;
seq: number;
}

interface IStreamSyncHistoryVertex {
Expand All @@ -37,6 +38,7 @@ interface IStreamSyncHistoryAddress {
interface IStreamSyncHistoryEnd {
type: 'stream:history:end';
id: string;
seq: number;
}

interface IStreamSyncHistoryError {
Expand Down Expand Up @@ -645,9 +647,10 @@ export class StreamManager extends AbortController {
}
}

endStream() {
endStream(seq: number) {
this.logger.debug('Received end-of-stream event.');
this.hasReceivedEndStream = true;
this.connection.sendStreamHistoryAck(this.streamId, seq);
}

async shutdown() {
Expand Down Expand Up @@ -713,7 +716,7 @@ function buildListener(manager: StreamManager, resolve: () => void) {
manager.generateNextBatch();
} else if (isStreamSyncHistoryEnd(wsData)) {
// cleanup and stop the method.
manager.endStream();
manager.endStream(wsData.seq);
resolve();
} else if (isStreamSyncHistoryError(wsData)) {
// An error happened on the fullnode, we should stop the stream
Expand Down