Skip to content

feat: send end ACK#762

Merged
r4mmer merged 1 commit intoreleasefrom
feat/send-end-ack
Sep 6, 2024
Merged

feat: send end ACK#762
r4mmer merged 1 commit intoreleasefrom
feat/send-end-ack

Conversation

@r4mmer
Copy link
Copy Markdown
Member

@r4mmer r4mmer commented Sep 6, 2024

Motivation

HathorNetwork/hathor-core#1129

Acceptance Criteria

  • Send end stream ACK

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this Sep 6, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (21a33bf) to head (58cbc81).
Report is 1 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release     #762      +/-   ##
===========================================
+ Coverage    80.38%   80.46%   +0.08%     
===========================================
  Files           79       79              
  Lines         6332     6333       +1     
  Branches      1379     1370       -9     
===========================================
+ Hits          5090     5096       +6     
+ Misses        1230     1225       -5     
  Partials        12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r4mmer r4mmer requested review from jansegre and msbrogli September 6, 2024 15:58
@r4mmer r4mmer merged commit ef71959 into release Sep 6, 2024
@r4mmer r4mmer deleted the feat/send-end-ack branch September 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants