Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add linting and formatting to CI #695

Merged
merged 3 commits into from
Jul 10, 2024
Merged

feat: Add linting and formatting to CI #695

merged 3 commits into from
Jul 10, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Jul 1, 2024

Acceptance Criteria

  • Linting of the src folder ( the tests folder will be implemented later )
  • Formatting of the entire application with prettier
  • Automatic formatting debt after Chore: Eslint automatic fixes #670
  • Explicit declaration of important eslint rules that will be left for later

Notes

This PR is separated into three commits for easier review in separate contexts: one for the workflow itself, other for the formatting technical debt and other for the rules that will be left for later

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the enhancement New feature or request label Jul 1, 2024
@tuliomir tuliomir self-assigned this Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.24%. Comparing base (409ed08) to head (f0bc6e9).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #695       +/-   ##
===========================================
+ Coverage   63.50%   80.24%   +16.73%     
===========================================
  Files          77       77               
  Lines        5957     5957               
  Branches     1303     1294        -9     
===========================================
+ Hits         3783     4780      +997     
+ Misses       2076     1159      -917     
+ Partials       98       18       -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir marked this pull request as ready for review July 9, 2024 17:19
@tuliomir tuliomir requested review from r4mmer and andreabadesso and removed request for pedroferreira1 July 9, 2024 17:19
@tuliomir tuliomir merged commit 94e458a into master Jul 10, 2024
4 checks passed
@tuliomir tuliomir deleted the feat/eslint-src-ci branch July 10, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Waiting to be deployed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants