-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Eslint automatic fixes #670
Conversation
2e2ac6d
to
9c8e433
Compare
d9ce45f
to
57e2dbe
Compare
9c8e433
to
2146330
Compare
2fcc073
to
81c994d
Compare
token: '00', | ||
changeAddress: null | ||
}, options); | ||
changeAddress: undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing a changeAddress
as null was not expected by the sendManyOutputsTransaction
method and had to be changed to undefined
to comply with the expected type changeAddress?: string;
. Otherwise the build phase would break.
The tests had to be changed accordingly. Since this is a static type issue, it's not expected that it will cause any issues with the wallet-lib consumers.
Notes
-
Another alternative solution would be adding
null
to the valid types for this parameter:changeAddress?: string | null
. -
This was previously not failing because instead of a simple object using the spread operator, the
Object.assign()
method was being used to build the parameters, bypassing the typescript checkers.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #670 +/- ##
===========================================
+ Coverage 62.79% 79.67% +16.88%
===========================================
Files 77 77
Lines 5886 5920 +34
Branches 1229 1280 +51
===========================================
+ Hits 3696 4717 +1021
+ Misses 2094 1185 -909
+ Partials 96 18 -78 ☔ View full report in Codecov by Sentry. |
Acceptance Criteria
prettier
should be appliedeslint --fix
should be appliedeslint --fix
( 81c994d )Security Checklist