Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release #1064 +/- ##
========================================
Coverage 87.93% 87.93%
========================================
Files 114 114
Lines 8910 8910
Branches 2020 2030 +10
========================================
Hits 7835 7835
Misses 1047 1047
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
892050a to
66607b8
Compare
9917220 to
c111886
Compare
Acceptance Criteria
Breaking Changes
From #1034 - feat: export all types and utils from public API:
The following types have been renamed at their source. External consumers importing the old names will need to update:
BalanceWalletServiceBalancesrc/wallet/types.tsAuthorityWalletServiceAuthoritysrc/wallet/types.tsDelegateAuthorityOptionsWalletServiceDelegateAuthorityOptionssrc/wallet/types.tsDestroyAuthorityOptionsWalletServiceDestroyAuthorityOptionssrc/wallet/types.tsCreateNanoTxDataFullnodeCreateNanoTxDatasrc/new/types.tsFrom #1038 - feat: single address policy:
HathorWalletdefault scan policy changed toSINGLE_ADDRESSThe constructor now defaults to
{ policy: SCANNING_POLICY.SINGLE_ADDRESS }when noscanPolicyis provided. Previously, omittingscanPolicyresulted inGAP_LIMITbehavior.Consumers that relied on the default gap-limit behavior must now explicitly pass a scan policy:
HathorWalletfirst-connection auto-detection of address modeOn the first WebSocket connection,
HathorWalletnow automatically:SINGLE_ADDRESS, attemptsenableSingleAddressMode().HasTxOutsideFirstAddressErrorand falls back toGAP_LIMIT.This behavior did not exist in v2.x.
HathorWallet.changeServer()is now asyncThe method signature changed from
changeServer(newServer: string): voidtoasync changeServer(newServer: string): Promise<void>. TypeScript consumers that type-check the return value will need to update.changeServer()added toIHathorWalletinterfaceThe
changeServer(newServer: string): Promise<void>method was added to theIHathorWalletinterface. Consumers that implement this interface directly will need to add this method.HathorWallet.getAddressAtIndex()no longer persists derived addressesPreviously, calling
getAddressAtIndex()for an index not yet in storage would derive the address and save it viathis.storage.saveAddress(address). It now derives and returns the address without persisting it.What's included
startSecurity Checklist