fix: native token version defaulting to DEPOSIT

[raul-oliveira]

Motivation

When the fullnode's /version endpoint returns native_token without a version field (e.g. { "name": "Hathor", "symbol": "HTR" }), getNativeTokenData() was producing an object with no version property. When this was later passed to memory_store.saveToken(), its default spread ({ version: TokenVersion.DEPOSIT, ...tokenConfig }) kicked in, incorrectly tagging HTR as DEPOSIT (1) instead of NATIVE (0).

Acceptance Criteria

• getNativeTokenData() always returns version: TokenVersion.NATIVE when the fullnode omits the version field
• getNativeTokenData() forwards the fullnode-provided version as-is (including unknown values like 99)
• getNativeTokenData() falls back to DEFAULT_NATIVE_TOKEN_CONFIG when native_token is null or version is not set
• saveNativeToken() round-trip through MemoryStore persists version: NATIVE, not DEPOSIT
• Custom tokens still default to TokenVersion.DEPOSIT in saveToken() (no regression)

Security Checklist

• Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

Summary by CodeRabbit

• Tests

  • Expanded test coverage for native token version handling scenarios, including cases with missing, unknown, or null version values.

• Bug Fixes

  • Ensured native tokens now explicitly include version information when retrieved from storage, with proper fallback behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 55269af1-9126-4bda-91ea-e142dde30979

📥 Commits

Reviewing files that changed from the base of the PR and between b408dd6 and 72ea6ec.

📒 Files selected for processing (2)

• __tests__/storage/storage.test.ts
• src/storage/storage.ts

---

📝 Walkthrough

Walkthrough

The changes expand native token versioning support by adding explicit version: TokenVersion.NATIVE field handling to the storage layer and its corresponding tests. Implementation ensures consistent version fields across all native token scenarios, with tests validating version handling for missing, explicit, unknown, and null cases.

Changes

Cohort / File(s)	Summary
Test Expansions __tests__/storage/storage.test.ts	Expanded native token config version behavior tests covering scenarios: no API version set, missing version field, explicit version preservation, unknown version forwarding, null handling, and post-save version validation. Added ApiVersion import.
Storage Implementation src/storage/storage.ts	Updated getNativeTokenData() to explicitly include version: TokenVersion.NATIVE in returned token data. Added TokenVersion import from types.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Suggested reviewers

• pedroferreira1
• tuliomir

Poem

🐰 A token's version, now held with care,
Native and versioned beyond compare,
Through storage it hops with field so true,
NATIVE it shouts in all that's new! 🎪

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the bug being fixed: native token version incorrectly defaulting to DEPOSIT instead of NATIVE.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch raul-oliveira/fix/native-token-version-from-storage

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.86%. Comparing base (29d2ff2) to head (eab9acc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1054       +/-   ##
===========================================
+ Coverage   66.53%   87.86%   +21.32%     
===========================================
  Files         114      114               
  Lines        8828     8828               
  Branches     2006     1996       -10     
===========================================
+ Hits         5874     7757     +1883     
+ Misses       2926     1043     -1883     
  Partials       28       28               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.