Merged
Conversation
43eb06d to
5916646
Compare
cb06200 to
e0caeb2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #968 +/- ##
==========================================
- Coverage 85.10% 85.08% -0.03%
==========================================
Files 296 295 -1
Lines 22909 22755 -154
Branches 3449 3443 -6
==========================================
- Hits 19497 19360 -137
+ Misses 2732 2710 -22
- Partials 680 685 +5 ☔ View full report in Codecov by Sentry. |
5916646 to
6c494e6
Compare
e0caeb2 to
20f5c6d
Compare
jansegre
approved these changes
Mar 27, 2024
msbrogli
approved these changes
Apr 16, 2024
20f5c6d to
04a8ed9
Compare
This was referenced May 2, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #967
Motivation
Since the
BaseTransaction.hashproperty has been converted fromOptional[bytes]tobytes, multiple assertions can be removed.Acceptance Criteria
assert tx.hash is not Noneand equivalent.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged