Conversation
glevco
force-pushed
the
chore/remove-migrations
branch
3 times, most recently
from
330bc52 to
9cebb0e
Compare
glevco
force-pushed
the
chore/remove-features
branch
from
89a625b to
ba93884
Compare
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
- Coverage 84.70% 84.62% -0.09%
==========================================
Files 313 313
Lines 24249 24246 -3
Branches 3690 3690
==========================================
- Hits 20541 20517 -24
- Misses 2997 3009 +12
- Partials 711 720 +9 ☔ View full report in Codecov by Sentry. |
msbrogli
previously approved these changes
Oct 23, 2024
glevco
force-pushed
the
chore/remove-migrations
branch
from
9cebb0e to
e169fe9
Compare
glevco
force-pushed
the
chore/remove-features
branch
from
ba93884 to
65cec01
Compare
jansegre
previously approved these changes
Oct 23, 2024
glevco
force-pushed
the
chore/remove-migrations
branch
from
e169fe9 to
741ee86
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
chore/remove-features
branch
from
65cec01 to
269e7a1
Compare
|
Bencher Report| Branch | chore/remove-features |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,480,162,835.08 (-0.82%) | 92,083,586,981.76 (90.74%) | 112,546,606,311.04 (90.17%) |
jansegre
approved these changes
Oct 29, 2024
msbrogli
approved these changes
Oct 29, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1149
Motivation
Since we are forcing recalculation of all metadata, we can remove unused features.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged