tests: fix CI regression on Windows + Python 3.10#926
Merged
Conversation
glevco
previously approved these changes
Jan 16, 2024
da8a255 to
d29d503
Compare
d29d503 to
9cf7d79
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #926 +/- ##
=======================================
Coverage 85.23% 85.24%
=======================================
Files 285 285
Lines 22370 22370
Branches 3371 3371
=======================================
+ Hits 19068 19069 +1
- Misses 2630 2632 +2
+ Partials 672 669 -3 ☔ View full report in Codecov by Sentry. |
glevco
approved these changes
Jan 16, 2024
1 task
msbrogli
approved these changes
Jan 16, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After #900 was merged it looks like the CI broke on Windows + Python 3.10 because when running a certain test that expects to reach Python's recursion limit, it will stack overflow instead. The reason why it happens is unclear, but since it's for a test that tests such a specific limit, it is better to adapt the test instead.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged