refactor(verification): remove BlockVerifier inheritance [part 4/9]

[glevco]

Depends on #832

Motivation

Simplify block verification by removing the BlockVerifier inheritance from MergeMinedBlockVerifier, as it was not necessary.

To do that, the main verification "entrypoints" (verify_basic(), verify(), and verify_without_storage()) are moved to the VerificationService, making it a single source of verification definition for all vertex types (the same will be done for other types in the next PRs).

This also guarantees that it's not possible to call BlockVerifier.verify() with a MergeMinedBlock, for example, which would be wrong. By using the single implementation from the VerificationService, we make sure the most specific verifier is called.

Acceptance Criteria

• Move verify_basic(), verify(), and verify_without_storage() from BlockVerifier to VerificationService.
• Move verify_without_storage() from MergeMinedBlockVerifier to VerificationService, removing its BlockVerifier inheritance, which is not needed anymore.
• Update usages accordingly.
• No behavior should be changed by this PR.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (965fba3) 85.24% compared to head (2d102bb) 85.28%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
+ Coverage   85.24%   85.28%   +0.03%     
==========================================
  Files         281      281              
  Lines       22390    22392       +2     
  Branches     3391     3391              
==========================================
+ Hits        19086    19096      +10     
+ Misses       2615     2610       -5     
+ Partials      689      686       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The base branch was changed.