Conversation
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #832 +/- ##
==========================================
- Coverage 85.30% 85.30% -0.01%
==========================================
Files 281 281
Lines 22367 22365 -2
Branches 3388 3388
==========================================
- Hits 19080 19078 -2
+ Misses 2605 2603 -2
- Partials 682 684 +2 ☔ View full report in Codecov by Sentry. |
6811073 to
005adad
Compare
c5854de to
a9a7081
Compare
005adad to
84f38ae
Compare
a9a7081 to
da35c7d
Compare
2e709e9 to
dc55893
Compare
da35c7d to
11a0131
Compare
dc55893 to
073d6f6
Compare
6309230 to
68a887d
Compare
9857b55 to
50171eb
Compare
68a887d to
4a9bd3e
Compare
50171eb to
5693c13
Compare
4a9bd3e to
a4bbe0f
Compare
a4bbe0f to
05498fa
Compare
msbrogli
approved these changes
Nov 23, 2023
jansegre
approved these changes
Nov 23, 2023
05498fa to
905d6bc
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #858
Motivation
Simplify
TokenCreationTransactionverification to remove any calls tosuper(), as it's not necessary.Acceptance Criteria
TokenCreationVerifier.verify_sum()override, moving its only custom check to a newverify_minted_tokens(), which is now explicitly called in theverify()override.verify_minted_tokens()totest_verification.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged