Skip to content

test(sync): Improve test_sync_rotate to prevent false positives #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msbrogli merged 1 commit into from
Oct 18, 2023
Merged

test(sync): Improve test_sync_rotate to prevent false positives #816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions tests/p2p/test_sync_enabled.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,20 @@ def test_sync_rotate(self):

self.simulator.run(600)

ready = set(conn for conn in connections if conn.proto1.is_state(conn.proto1.PeerState.READY))
self.assertEqual(len(ready), len(other_managers))

enabled = set(conn for conn in connections if conn.proto1.is_sync_enabled())
self.assertTrue(len(enabled), 3)
self.assertEqual(len(enabled), 3)

manager1.connections._sync_rotate_if_needed(force=True)
enabled2 = set(conn for conn in connections if conn.proto1.is_sync_enabled())
self.assertTrue(len(enabled2), 3)
# Chance of false positive: 1/comb(20, 3) = 0.0008771929824561404
self.assertEqual(len(enabled2), 3)
if enabled == enabled2:
manager1.connections._sync_rotate_if_needed(force=True)
enabled2 = set(conn for conn in connections if conn.proto1.is_sync_enabled())
self.assertEqual(len(enabled2), 3)
# Chance of false positive: (1/comb(15, 3))**2 = 0.00000483
self.assertNotEqual(enabled, enabled2)


Expand Down